Skipping empty string in update expressions as it used to convert to …#28
Open
EvgeniyHablak wants to merge 1 commit intomasterfrom
Open
Skipping empty string in update expressions as it used to convert to …#28EvgeniyHablak wants to merge 1 commit intomasterfrom
EvgeniyHablak wants to merge 1 commit intomasterfrom
Conversation
…nil which results in SerializationException;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made
key.go — Empty string hash key validation
isValidHashKey() now rejects empty string hash key values in addition to nil. This catches the problem early with a clear ErrInvalidHashKeyValue error instead of a cryptic SerializationException from AWS.
dynamo_repository.go — Skip empty strings in update expressions
Added isEmptyString() helper function
Both UpdateWithContext() and prepareUpdateWithUpdateExpressions() now skip any value that is an empty string ("") when building Set, SetSet, SetIfNotExists, and Add expressions. This prevents guregu/dynamo from marshaling empty strings to nil *dynamodb.AttributeValue, which was causing the SerializationException.