fix(design-data): decompose stack-item background-highlight fusion (284) - #1317
Merged
Merged
Conversation
Last remaining fused name.property in the corpus: the stack-item selected/highlight background-color alias fused an object segment (background) into its property string. - packages/design-data/tokens/color-aliases.tokens.json: split stack-item-background-color into object:"background" + property:"color". No component field added -- the legacy reference data for this cross-component alias never tagged it with one, so legacyKey is the only place "stack-item" is preserved. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c8066f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
Run report for c8066f6eTotal time: 2m 34s | Comparison time: 3m 20s | Estimated savings: 46.6s (23.2% faster)
Expanded report
Changed files |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes out epic spectrum-design-data-284 (fused
name.propertydecomposition). This wasthe last remaining fused property in the whole corpus, found via a re-run of the
tools/token-mapping-analyzerresidue analyzer after #1315 merged.stack-item-selected-background-color-highlighttoken's fusedstack-item-background-colorproperty into
object:"background"+property:"color". Nocomponentfield was added —the legacy reference data (
packages/tokens/src) for this cross-component alias nevertagged it with one (unlike sibling
stack-item-background-color-*tokens incolor-component.tokens.json, which do carrycomponent:"stack-item"because theirlegacy reference does too). Adding
componenthere caused a reallegacy-verifymismatch, so
stack-itemstays only in the pinnedlegacyKey.Related Issue
Closes spectrum-design-data-284.
Motivation and Context
node tools/token-mapping-analyzer/src/index.jsnow reportsFused properties (active): 0— every
name.propertyin the corpus is atomic.How Has This Been Tested?
cargo run -p design-data-cli -- migrate legacy-verify— legacy output OK, byte-identical.cargo run -p design-data-cli -- migrate roundtrip-verify— roundtrip OK.moon run design-data:validate sdk:test sdk:lint— all green.moon run :test(JS/AVA) — all green except the pre-existingsdk-wasm:testparityfailure (
Dataset.embedded() query result .raw is a plain object, not a Map), alreadyconfirmed unrelated (fails identically on
main).Types of changes
Checklist: