This repository was archived by the owner on Apr 27, 2026. It is now read-only.
MWPW-192736: Add check for milolibs query param#1325
Merged
Conversation
… XSS The milolibs and unitylibs query params were interpolated directly into template literals used for dynamic import()s, letting an attacker point module loading at an arbitrary origin and execute JS in the page context. Add a strict whitelist (^[a-zA-Z0-9_-]+$) and throw on invalid input in head.html, acrobat/scripts/utils.js, acrobat/scripts/scripts.js, and acrobat/blocks/unity/unity.js. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
zagi25
changed the title
JingleH
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whitelist branch parameter with
/^[a-zA-Z0-9_-]+$/; throw on any other characters.Ticket
https://jira.corp.adobe.com/browse/MWPW-192736
Test URLs
Before: https://stage--dc--adobecom.aem.page/
After: https://MWPW-192736-dc--da-dc--zagi25.aem.page/
This PR was generated by Claude (Anthropic's Claude Code CLI).