[Release] Stage to Main#5927
Open
milo-pr-merge[bot] wants to merge 2 commits into
Open
Conversation
* MWPW-191951: Detect unpublished M@S fragments in Preflight Adds an M@S unpublished-fragment check to the Preflight modal. Scans every <aem-fragment fragment> on the page, calls the Adobe MAS fragment API per UUID, and surfaces 404s as a CRITICAL fail through the shared preflight aggregator. - New checks/merch.js: findFragmentElements, checkFragmentPublished, checkUnpublishedFragments (with diagnostic log), runChecks factory. - preflightApi.js: wires merch into the runChecks aggregator and hasFailures result. - panels/merch.js: M@S panel renders an "Unpublished Fragments" section using the shared helper; affected cards get a "Not published" badge, red outline, and diagonal hatch overlay. - preflight-notification.js: appends an additive M@S line to the failure toast (no hard-block). - preflight.css: .preflight-mas-unpublished outline, hatch background, and corner badge styles. - Unit tests cover element discovery, fetch status mapping, aggregator output, runChecks pass/fail, and API URL shape. * MWPW-191951: Replace console.log with lana and fix hardcoded font-family - Replace console.log + eslint-disable with window.lana logging (only on unpublished) - Replace hardcoded Adobe Clean font-family with var(--body-font-family) * chore: re-trigger CI
Contributor
Author
|
Testing can start @adobecom/bacom-sot @adobecom/creative-cloud-sot @adobecom/document-cloud-sot @adobecom/express-sot @adobecom/homepage-sot @adobecom/miq-sot @adobecom/blog-sot |
Contributor
Contributor
|
SNOW Change Request Transaction ID: 0000019c1ef37582-e7eb895 |
Adds comprehensive end-to-end test coverage for the Floodgate for DA tool (MWPW-189268) running against da.live with the da-floodgate branch. What's included: - Page Object Model with iframe + shadow DOM traversal (floodgate.page.js) - 51 test cases across 7 suites: Page Load, Path Validation, Copy (Simple + Real Events), Content Integrity, Promote, Delete, Cancel/Retry, E2E Smoke Chain - Real-content seed script that pulls 5 production event pages + their fragments into a sandbox at /drafts/nala-fg-test/ - DA login helper that saves a Playwright storageState for test reuse - Self-healing test data hooks via DA admin API (ensureFileInFg) so delete tests don't break each other - Byte-level source-vs-FG content comparator that normalizes URL rewrites and verifies CaaS-encoded payload preservation - Full English TEST-PLAN.md with execution instructions and risk register Test execution: - 51 tests, 49 pass, 2 intentional skips, 0 failures - ~7 min runtime at workers=1 - Verified Bugs #1 (runtime fragment discovery) and #2 (.link file handling) are now fixed in the da-floodgate branch Auth setup: - Run `node nala/utils/da-login.js` once to create auth.json (gitignored) - Tests reuse the storageState; no credentials in code Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
common base root URLs
Homepage : https://www.stage.adobe.com/
BACOM: https://business.stage.adobe.com/fr/
CC: https://www.stage.adobe.com/creativecloud.html
Blog: https://blog.stage.adobe.com/
Acrobat: https://www.stage.adobe.com/acrobat/online/sign-pdf.html
Milo: