Conversation
modified: toxic_comments/data/make_dataset.py
new file: local_hosting/bert-base-uncased-vocab.txt
new file: local_hosting/dtm.py
new file: local_hosting/fastapi/app/__init__.py
new file: local_hosting/fastapi/app/main.py
new file: local_hosting/fastapi/fast.py
new file: local_hosting/fastapi/requirements.txt
new file: local_hosting/handler.py
new file: local_hosting/index_name.py
new file: local_hosting/index_to_name.json
new file: local_hosting/sample_text.txt
new file: local_hosting/setup_config_serve.json
modified: toxic_comments/models/config/default.yaml
modified: toxic_comments/predict_model.py
modified: toxic_comments/train_model.py
deleted: serving/bert-base-uncased-vocab.txt
deleted: serving/dtm.py
deleted: serving/handler.py
deleted: serving/index_name.py
deleted: serving/index_to_name.json
deleted: serving/sample_text.txt
deleted: serving/setup_config_serve.json
deleted: serving/dtm.py deleted: serving/handler.py deleted: serving/index_name.py deleted: serving/index_to_name.json deleted: serving/sample_text.txt deleted: serving/setup_config_serve.json
new file: fastapi/__init__.py renamed: local_hosting/fastapi/app/main.py -> fastapi/main.py renamed: local_hosting/fastapi/requirements.txt -> fastapi/requirements.txt deleted: local_hosting/fastapi/fast.py renamed: local_hosting/fastapi/app/__init__.py -> slowapi/__init__.py new file: slowapi/main.py new file: slowapi/requirements.txt
new file: local_hosting/fastapi/main.py new file: slowapi/ask.py new file: slowapi/templates/1.html modified: toxic_comments/predict_model.py
modified: toxic_comments/__init__.py modified: toxic_comments/predict_model.py renamed: slowapi/__init__.py -> toxic_comments/slowapi/__init__.py renamed: slowapi/ask.py -> toxic_comments/slowapi/ask.py renamed: slowapi/main.py -> toxic_comments/slowapi/main.py renamed: slowapi/requirements.txt -> toxic_comments/slowapi/requirements.txt renamed: slowapi/templates/1.html -> toxic_comments/slowapi/templates/1.html
deleted: fastapi/main.py deleted: fastapi/requirements.txt modified: toxic_comments/predict_model.py
deleted: fastapi/main.py deleted: fastapi/requirements.txt
adoprox
commented
Jan 17, 2024
Owner
Author
adoprox
left a comment
adoprox
left a comment
There was a problem hiding this comment.
The local hosting folder and the slowapi folder are new for hosting the model locally and using flask app. The other new files are web.dockerfile and yaml for creating the container on gcp.
I trained the model using different config so maybe don't merge that.
In predict_model.py I added a comment and that's all, also no changes in make_dataset and init.py.
Hopefully should not break anything just adding features to locally host and host using gcp.
adoprox
commented
Jan 17, 2024
Owner
Author
adoprox
left a comment
adoprox
left a comment
There was a problem hiding this comment.
jajjaa deleted fastapi folder, messing with the ruff tests
adoprox
commented
Jan 17, 2024
Owner
Author
adoprox
left a comment
adoprox
left a comment
There was a problem hiding this comment.
changes made in train_model.py removed my function to save mode variables, should not mess with the main branch or break code.
removed fastapi unused imports
andste97
approved these changes
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.