jpom IEEE parser#182
Conversation
| # Conference location | ||
| if self.publicationinfo.find("conflocation") is not None: | ||
| confloc = self.publicationinfo.find("conflocation").text | ||
| self.base_metadata["conf_location"] = confloc |
There was a problem hiding this comment.
This line will fail if self.publicationinfo.find("conflocation") is None -- the variable confloc will be undefined at L96.
seasidesparrow
left a comment
seasidesparrow
left a comment
There was a problem hiding this comment.
Good first round. You need to make sure the project passes existing IEEE unit tests, and then add unit tests specifically for conference proceedings.
| # self.base_metadata["collection"] = colls_uniq | ||
|
|
||
| # TO DO: append confDates & confLocation to %J | ||
| if confdate: |
There was a problem hiding this comment.
You need an option to not output confloc if it is NoneType or ""
| # Article sequence number | ||
| if articleinfo.find("articleseqnum"): | ||
| articleid = articleinfo.find("articleseqnum").get_text() | ||
| self.base_metadata["electronic_id"] = articleid |
There was a problem hiding this comment.
Ideally, if there are firstPage, lastPage and articleseqnum, I'd like to field all three. Right now, the existing test cases have a firstPage and lastPage under pagination, so I'd like to add electronicID rather than using it exclusively.
| # Conference volume number | ||
| if self.volumeinfo: | ||
| self.base_metadata["volume"] = self.volumeinfo.find("volumenum").get_text() | ||
| self.base_metadata["issue"] = self.volumeinfo.find("issue").find("issuenum").get_text() |
There was a problem hiding this comment.
Restore L50, because you're losing issue numbers when available.
| else: | ||
| self.base_metadata["volume"] = "" | ||
|
|
||
| # Conferences don't have an issue number |
There was a problem hiding this comment.
Ideally, the parser should be able to handle both conferences and journal articles without giving special instructions to the parser.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #182 +/- ##
==========================================
- Coverage 91.05% 81.36% -9.70%
==========================================
Files 25 27 +2
Lines 3073 3439 +366
==========================================
Hits 2798 2798
- Misses 275 641 +366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
IEEE parser