Upgrade biblib to Python 3.12#189
Open
femalves wants to merge 2 commits into
Open
Conversation
|
Coverage is 93.651% — upgrade/python-3.12 into master. No base build found for |
femalves
force-pushed
the
upgrade/python-3.12
branch
from
feeae19 to
5591744
Compare
femalves
force-pushed
the
upgrade/python-3.12
branch
from
5591744 to
f2c19a2
Compare
femalves
force-pushed
the
upgrade/python-3.12
branch
from
f2c19a2 to
2f41ee8
Compare
tjacovich
reviewed
May 22, 2026
Contributor
tjacovich
left a comment
tjacovich
left a comment
There was a problem hiding this comment.
Looks like a solid upgrade. Just a couple of questions about specific implementation details.
| - name: Install dependencies | ||
| run: | | ||
| python -m pip install "pip==24" setuptools==57.5.0 wheel | ||
| python -m pip install "pip==24" "setuptools>=62.0.0,<70.0.0" wheel |
Contributor
There was a problem hiding this comment.
Out of curiosity, what packages break with setuptools >70?
| from biblib.manage import DeleteObsoleteVersionsNumber, DeleteStaleUsers, DeleteObsoleteVersionsTime | ||
| from biblib.models import User, Library, Permissions, Notes | ||
| from sqlalchemy.orm.exc import NoResultFound | ||
| from sqlalchemy import text |
Contributor
There was a problem hiding this comment.
Is this strictly input sanitization?
|
|
||
| import uuid | ||
| from datetime import datetime | ||
| from datetime import datetime, timezone |
Contributor
There was a problem hiding this comment.
Did something change in sqlalchemy that now requires us to explicitly strip the timezone?
Contributor
There was a problem hiding this comment.
This is an interesting way to solve the relocated config. We can talk more about it at our next weekly and decide if this is how we want to do it going forward?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is failing because the adsmutils@2.0.0 doesn't exist yet. Will create it after adsabs/ADSMicroserviceUtils#48 is approved.
These changes are in dev right now.