Applied skeletal implementation to interface migration automated refactoring#747
Closed
khatchad wants to merge 1 commit intoadvantageous:masterfrom
Closed
Applied skeletal implementation to interface migration automated refactoring#747khatchad wants to merge 1 commit intoadvantageous:masterfrom
khatchad wants to merge 1 commit intoadvantageous:masterfrom
Conversation
Member
|
Tests don't pass |
Author
|
Our apologies. It looks like some of the migrations crossed gradle module boundaries. In this case, we can choose whether to update the gradle build file dependencies or reject the problematic migrations (we have an outstanding bug to deal with gradle build files). We'll recommit the latter as it is less invasive in the case that is something you are interested in. |
Author
|
Revised version in pull request #767. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a semantics-preserving refactoring that migrates existing method implementations in classes to the corresponding implemented interface methods as
defaultmethods. The tool does not add new code; it only rearranges existing code.The current state of this code does not seem to compile as some of the migrated method implementations cross gradle module boundaries. Still, any feedback you can supply would be helpful. Also, please let us know if new module dependencies would be acceptable.
Thank you for your help in this evaluation! Any feedback you can provide would be very helpful. In particular, we are interested if each of the proposed changes are helpful or not.