perf: network optimizations by orangishcat · Pull Request #108 · aehmttw/Tanks

orangishcat · 2025-09-10T06:15:32Z

deletes half the codebase

Reflection handler to populate event fields without additional code
Trimmed all doubles to floats and some ints to shorts
Changed Game.networkRate from 60 to 20
Overall, reduced network traffic (upstream/downstream) by around 80%

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat · 2025-09-10T06:15:50Z

Marking as draft as there are still strange interpolation issues i need to fix (will do tmrw)

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat · 2025-09-15T23:15:34Z

Additional changes and stuff to test:

Explosions now destroy properly on client side, don't emit duplicate destroy events (thanks furret)
Stackable events are placed in linked hash maps to preserve stacked event order
Applied continuous shooting to bullets with less than 10 cooldown
Made bullet shoot and bullet destroy events stackable for bullets with zero cooldown
Added EventSetItemCount to replace EventSetItem when only the count of the item has changed
Made a bunch more events stackable to reduce network load
Added Game.recordEventData "Record event data" debug option to record network KB/s of each event every second
Quick actions is now sent through the network encoded as an int (thanks F6)
Fixed EventTankUpdateHealth to display the correct health value at all times
Added validation upon game launch of network events to ensure every read call is paired with a write call
Extracted duplicate functionality in ServerHandler and ClientHandler into NetworkHandler
Probably more that I forgot about

Also double check interpolation so that the tank id 0 tank isn't stuck in the corner or anything

# Conflicts: # src/main/java/tanks/Game.java # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

aehmttw · 2025-12-01T08:24:02Z

Screen Shot 2025-12-01 at 2 23 11 AM (2)

the tank health is not consistent

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/Game.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventAddNPCShopItem.java # src/main/java/tanks/network/event/EventAddShopItem.java # src/main/java/tanks/network/event/EventSortShopButtons.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

# Conflicts: # src/main/java/tanks/network/event/EventExplosion.java

ghostlypi

I've flagged a few changes which are purely syntactic and unecessary for the function of the pull request. Some of these issues will be addressed when the branch is linted, however it is important to note that it's annoying to have to review this because first, syntactic and technical changes need to be separated before any evaluation as to the correctness of optimizations can be done.

Additionally the issue with FastUtil is that it does not work on iOS. I think it's worth not using until FastUtil can be made to work on iOS.

ghostlypi · 2026-03-16T00:59:28Z

 		if (this.effect == Operation.add)
 			return in + val;
-		else if (this.effect == Operation.multiply)
+		if (this.effect == Operation.multiply)


This is not really an optimization. I think it's more of a syntactic difference than anything else.

ghostlypi · 2026-03-16T01:00:44Z

 		for (ArrayList<Trail> trail : this.trails)
 		{
-			if (trail.size() > 0)
+			if (!trail.isEmpty())


This is another syntactic difference, not a performance optimization.

ghostlypi · 2026-03-16T01:01:44Z

 			if (this.usable(t) && !this.destroy)
 			{
-				use(t);
+                use(t);


What is going on here?

ghostlypi · 2026-03-16T01:02:15Z

 import io.netty.buffer.ByteBuf;
-import tanks.Drawing;
-import tanks.Game;
+import tanks.*;


A lot of this stuff has been fixed by linting so I recommend you rebase. It should also help keep the code everyone writes consistent.

Also, these are notatbly not optimizations.

ghostlypi · 2026-03-16T01:03:33Z

-        }
-    }
-}
+package tanks.network.event;


A change like this is annoying to review because the whole file is marked as a diff. Actually seeing the diff for things like this is not fun.

ghostlypi · 2026-03-16T01:04:49Z

-    public boolean action1;
-    public boolean action2;
-    public boolean[] quickActions = new boolean[TankPlayer.max_abilities];
+    public int tank, quickActions;


I really am not a fan of putting imports on the same line. It's better to keep them separated than put them all together. Also this is a syntactic change, not an optimization.

orangishcat · 2026-03-16T23:00:34Z

Fastutil is not essential, most of the changes work without it.

ghostlypi · 2026-03-17T03:33:25Z

Can you re-base, lint, and reformat to make this easier to merge?

orangishcat · 2026-03-17T03:58:33Z

Yeah I need to fix all the merge conflicts first

# Conflicts: # src/main/java/tanks/AreaEffectFreeze.java # src/main/java/tanks/Chunk.java # src/main/java/tanks/DebugKeybinds.java # src/main/java/tanks/Game.java # src/main/java/tanks/Level.java # src/main/java/tanks/ModAPI.java # src/main/java/tanks/Panel.java # src/main/java/tanks/attribute/AttributeModifier.java # src/main/java/tanks/bullet/Bullet.java # src/main/java/tanks/bullet/BulletAirStrike.java # src/main/java/tanks/bullet/BulletInstant.java # src/main/java/tanks/bullet/BulletReboundIndicator.java # src/main/java/tanks/gui/screen/ScreenDebug.java # src/main/java/tanks/item/Item.java # src/main/java/tanks/network/Client.java # src/main/java/tanks/network/ClientHandler.java # src/main/java/tanks/network/MessageReader.java # src/main/java/tanks/network/NetworkEventMap.java # src/main/java/tanks/network/NetworkUtils.java # src/main/java/tanks/network/Server.java # src/main/java/tanks/network/ServerHandler.java # src/main/java/tanks/network/event/EventAddColoredTile.java # src/main/java/tanks/network/event/EventAddFixedShape.java # src/main/java/tanks/network/event/EventAddNPC.java # src/main/java/tanks/network/event/EventAddObstacle.java # src/main/java/tanks/network/event/EventAddObstacleBullet.java # src/main/java/tanks/network/event/EventAddObstacleText.java # src/main/java/tanks/network/event/EventAddScoreboard.java # src/main/java/tanks/network/event/EventAirdropTank.java # src/main/java/tanks/network/event/EventAnnounceConnection.java # src/main/java/tanks/network/event/EventArcadeClearMovables.java # src/main/java/tanks/network/event/EventArcadeFrenzy.java # src/main/java/tanks/network/event/EventBeginLevelCountdown.java # src/main/java/tanks/network/event/EventBulletBounce.java # src/main/java/tanks/network/event/EventBulletDestroyed.java # src/main/java/tanks/network/event/EventBulletInstantWaypoint.java # src/main/java/tanks/network/event/EventBulletReboundIndicator.java # src/main/java/tanks/network/event/EventBulletStunEffect.java # src/main/java/tanks/network/event/EventBulletUpdateTarget.java # src/main/java/tanks/network/event/EventChangeBackgroundColor.java # src/main/java/tanks/network/event/EventChangeScoreboardAttribute.java # src/main/java/tanks/network/event/EventChat.java # src/main/java/tanks/network/event/EventClearNPCShop.java # src/main/java/tanks/network/event/EventClearShop.java # src/main/java/tanks/network/event/EventConnectionSuccess.java # src/main/java/tanks/network/event/EventCreateFreezeEffect.java # src/main/java/tanks/network/event/EventDisplayText.java # src/main/java/tanks/network/event/EventDisplayTextGroup.java # src/main/java/tanks/network/event/EventEnterLevel.java # src/main/java/tanks/network/event/EventItemDrop.java # src/main/java/tanks/network/event/EventItemPickup.java # src/main/java/tanks/network/event/EventKick.java # src/main/java/tanks/network/event/EventLayMine.java # src/main/java/tanks/network/event/EventLevelExit.java # src/main/java/tanks/network/event/EventLevelFinished.java # src/main/java/tanks/network/event/EventLoadItemBarSlot.java # src/main/java/tanks/network/event/EventLoadLevel.java # src/main/java/tanks/network/event/EventMutePlayer.java # src/main/java/tanks/network/event/EventNudge.java # src/main/java/tanks/network/event/EventObstacleBoostPanelEffect.java # src/main/java/tanks/network/event/EventObstacleDestroy.java # src/main/java/tanks/network/event/EventObstacleShrubberyBurn.java # src/main/java/tanks/network/event/EventPing.java # src/main/java/tanks/network/event/EventPlayerAutoReady.java # src/main/java/tanks/network/event/EventPlayerAutoReadyConfirm.java # src/main/java/tanks/network/event/EventPlayerChat.java # src/main/java/tanks/network/event/EventPlayerReady.java # src/main/java/tanks/network/event/EventPlayerRevealBuild.java # src/main/java/tanks/network/event/EventPlayerSetBuild.java # src/main/java/tanks/network/event/EventPurchaseBuild.java # src/main/java/tanks/network/event/EventPurchaseNPCItem.java # src/main/java/tanks/network/event/EventReturnToCrusade.java # src/main/java/tanks/network/event/EventReturnToLobby.java # src/main/java/tanks/network/event/EventScoreboardUpdateScore.java # src/main/java/tanks/network/event/EventSendClientDetails.java # src/main/java/tanks/network/event/EventSendTankColors.java # src/main/java/tanks/network/event/EventSetItem.java # src/main/java/tanks/network/event/EventSetItemBarSlot.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventSetupHotbar.java # src/main/java/tanks/network/event/EventShareCrusade.java # src/main/java/tanks/network/event/EventShareLevel.java # src/main/java/tanks/network/event/EventShootBullet.java # src/main/java/tanks/network/event/EventShowCrusadeStats.java # src/main/java/tanks/network/event/EventSortNPCShopButtons.java # src/main/java/tanks/network/event/EventTankAddAttributeModifier.java # src/main/java/tanks/network/event/EventTankCharge.java # src/main/java/tanks/network/event/EventTankControllerUpdateC.java # src/main/java/tanks/network/event/EventTankControllerUpdateS.java # src/main/java/tanks/network/event/EventTankCreate.java # src/main/java/tanks/network/event/EventTankCustomCreate.java # src/main/java/tanks/network/event/EventTankMimicLaser.java # src/main/java/tanks/network/event/EventTankMimicTransform.java # src/main/java/tanks/network/event/EventTankPlayerCreate.java # src/main/java/tanks/network/event/EventTankSpawn.java # src/main/java/tanks/network/event/EventTankTeleport.java # src/main/java/tanks/network/event/EventTankTransformCustom.java # src/main/java/tanks/network/event/EventTankTransformPreset.java # src/main/java/tanks/network/event/EventTankUpdate.java # src/main/java/tanks/network/event/EventTankUpdateColor.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java # src/main/java/tanks/network/event/EventTankUpdateVisibility.java # src/main/java/tanks/network/event/EventUpdateCoins.java # src/main/java/tanks/network/event/EventUpdateEliminatedPlayers.java # src/main/java/tanks/network/event/EventUpdateReadyPlayers.java # src/main/java/tanks/network/event/EventUpdateRemainingLives.java # src/main/java/tanks/network/event/EventUpdateTankAbility.java # src/main/java/tanks/network/event/INetworkEvent.java # src/main/java/tanks/network/event/IStackableEvent.java # src/main/java/tanks/network/event/PersonalEvent.java # src/main/java/tanks/network/event/online/EventAddButton.java # src/main/java/tanks/network/event/online/EventAddMenuButton.java # src/main/java/tanks/network/event/online/EventAddShape.java # src/main/java/tanks/network/event/online/EventAddText.java # src/main/java/tanks/network/event/online/EventAddTextBox.java # src/main/java/tanks/network/event/online/EventAddUUIDTextBox.java # src/main/java/tanks/network/event/online/EventSendLevelToDownload.java # src/main/java/tanks/network/event/online/EventSendOnlineClientDetails.java # src/main/java/tanks/network/event/online/EventSetPauseScreenTitle.java # src/main/java/tanks/network/event/online/EventUploadLevel.java # src/main/java/tanks/obstacle/Obstacle.java # src/main/java/tanks/tank/Mine.java # src/main/java/tanks/tank/Tank.java # src/main/java/tanks/tank/TankPlayerRemote.java # src/main/java/tanks/tank/TankRemote.java

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat added 12 commits September 9, 2025 23:10

refactor: create NetworkHandler for shared properties

7e13d4c

Signed-off-by: orangishcat <fdsnail2@gmail.com>

feat: network optimizations, reflection handlers

1a24258

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: network event fixes

dc4832d

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: use shorts for colors

fb7aec3

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix(network): network-related bug fixes

f45056b

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix(EventTankUpdateHealth): shield fix

7057b13

Signed-off-by: orangishcat <fdsnail2@gmail.com>

style: minor code style changes

5584102

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: shoot bullet event

817e29f

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: remove stacked group event

6c39fa7

Signed-off-by: orangishcat <fdsnail2@gmail.com>

feat: more network validation checks

c60e604

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: interpolation bug

ddda007

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: more interpolation bugs

096f35e

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat added 9 commits September 10, 2025 17:16

fix: explosion bug

c1082d4

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: partial angle interpolation fix

8073cbc

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: duplicate obstacle destroy events from explosion

db1605a

Signed-off-by: orangishcat <fdsnail2@gmail.com>

refactor: extract duplicate code

60b3738

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: preserve order by batching all events

cf18fbb

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix,style: make more events stackable, optimize imports

8fc13e4

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: make instant waypoint events stackable

f92fab3

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: optimize network load of 0 cooldown items

d4a8853

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: change debug option back to false

b8b0483

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat marked this pull request as ready for review September 14, 2025 06:44

orangishcat added 4 commits September 14, 2025 10:55

fix: stack bullet events only for zero cooldown shots

455f8c5

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: continuous shooting only for low cooldown bullets,

0d47c5c

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: set event data debug to false

a8dfed6

Signed-off-by: orangishcat <fdsnail2@gmail.com>

perf: use int for quick actions encoding

3ff9442

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat changed the title ~~feat: network optimizations~~ perf: network optimizations Sep 15, 2025

Merge branch 'remote-master' into network-optimization-cleaned

c91254a

# Conflicts: # src/main/java/tanks/Game.java # src/main/java/tanks/hotbar/ItemBar.java # src/main/java/tanks/network/event/EventSetItemCount.java # src/main/java/tanks/network/event/EventTankUpdateHealth.java

orangishcat added 2 commits November 8, 2025 12:51

chore: update branch

6db2cf0

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: event lay mine

b5f74cf

Signed-off-by: orangishcat <fdsnail2@gmail.com>

aehmttw reviewed Dec 1, 2025

View reviewed changes

Comment thread src/main/java/tanks/Game.java Outdated

aehmttw reviewed Dec 1, 2025

View reviewed changes

Comment thread src/main/java/tanks/bullet/Bullet.java Outdated

orangishcat added 7 commits December 1, 2025 09:10

fix: sounds not playing on client side

0b6a164

Signed-off-by: orangishcat <fdsnail2@gmail.com>

fix: add sounds back, fix tank health inconsistency

d96c4cf

Signed-off-by: orangishcat <fdsnail2@gmail.com>

Merge branch 'remote-master' into network-optimization-cleaned

8d98c11

# Conflicts: # src/main/java/tanks/Game.java

chore: update branch

058a962

Signed-off-by: orangishcat <fdsnail2@gmail.com>

chore: update branch, fix build errors

f7c9d1d

Signed-off-by: orangishcat <fdsnail2@gmail.com>

Merge branch 'remote-master' into network-optimization-cleaned

b4d0125

# Conflicts: # src/main/java/tanks/network/event/EventExplosion.java

ghostlypi reviewed Mar 16, 2026

View reviewed changes

orangishcat added 2 commits March 28, 2026 22:32

chore: merge branch

15c9203

Signed-off-by: orangishcat <fdsnail2@gmail.com>

orangishcat force-pushed the network-optimization-cleaned branch from 4bc4a9a to 15c9203 Compare March 29, 2026 06:17

Conversation

orangishcat commented Sep 10, 2025

Uh oh!

orangishcat commented Sep 10, 2025

Uh oh!

orangishcat commented Sep 15, 2025

Uh oh!

Uh oh!

Uh oh!

aehmttw commented Dec 1, 2025

Uh oh!

ghostlypi left a comment

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

ghostlypi Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

orangishcat commented Mar 16, 2026

Uh oh!

ghostlypi commented Mar 17, 2026

Uh oh!

orangishcat commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants