(feat) Streams: "_map" methods to return an Option for empty/null xread response#364
Open
danwritecode wants to merge 4 commits intoaembke:mainfrom
Open
(feat) Streams: "_map" methods to return an Option for empty/null xread response#364danwritecode wants to merge 4 commits intoaembke:mainfrom
danwritecode wants to merge 4 commits intoaembke:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey All, for xread_map and xreadgroup_map, these methods currently return a Result for situations where a stream has no records and you get an empty or NULL response.
I think a pragmatic change here would be to check the Value returned from xread and return None in the event that the Value is null instead of returning an Error result.
It's totally expected/reasonable that a stream will be empty at any point and time and it's important to know when there are no records available for processing vs when an actual error occurs.