Update AddonRecipeNote #1711
Open
Update AddonRecipeNote #1711
+52
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
breaking change
Contributor
Breaking ChangesMember exists in left but not in rightFFXIVClientStructs.FFXIV.Client.UI: 1AddonRecipeNote: 5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I split this PR into two separate commits:
With the new fields, it is possible to gain access to the data from the removed fields, and provide more detail in general to users of the struct. I would be willing to resubmit the PR with only the offset updates if adding new fields is undesirable. I am also willing to rename or change any names I chose for these fields if there are issues with them.