Open
Conversation
To avoid breaking change to `async.whilst`. In 1.5.2 and earlier, the first function of `async.whilst` returns `true` while the second function is to be called, but in later version of `async` the function itself takes a callback as argument and calls it to determine whether to continue to the second function.
Author
|
node_airtunes/lib/udp_servers.js Line 109 in 7e2d5f6 In the current version (as of May 2021) of async, the first function takes a callback as argument (see docs). In 1.5.2, returning a boolean is the expected behavior. The result of using a modern version of async is that the second callback will never be called, preventing the ports from ever being bound. This should fix the issue in babelpod here: afaden/babelpod#17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid breaking change to
async.whilst. In 1.5.2 and earlier, the first function ofasync.whilstreturnstruewhile the second function is to be called, but in later version ofasyncthe function itself takes a callback as argument and calls it to determine whether to continue to the second function.