feat(health): improve health center issue details for negative balance and FX integrity#830
Merged
afadil merged 9 commits intoafadil:mainfrom Apr 13, 2026
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add affected_items to all three FX integrity issue types (missing, stale error, stale warning) so the detail sheet lists each impacted currency pair (e.g. EUR → USD) instead of only a count. Also move NegativeBalanceInfo import into #[cfg(test)] block in env.rs to fix unused import warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @afadil,
I hope you are doing great.
I did some changes for the health center, to help the user got more informations to solve the issues.
Specially regarding negative balance and Fx integrity.
Summary
Improves the Health Center issue drawer with more actionable details for two issue types.
Negative Balance (Data Consistency)
FX Integrity
Other
NegativeBalanceInfoincrates/ai/src/env.rsKey files changed
crates/core/src/health/checks/data_consistency.rs— negative balance logic and detailscrates/core/src/health/checks/fx_integrity.rs— FX affected itemscrates/core/src/portfolio/valuation/—NegativeBalanceInfomodel and queryTest plan
Checklist
By submitting this PR, I agree to the CLA.