feat(events): add a selector for easier event comparison #1575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agallou
reviewed
Dec 29, 2024
agallou
reviewed
Dec 29, 2024
Contributor
Author
|
Cette PR est en draft d'où les changements incomplets. Je me suis inspiré de la liste déroulante existante car c'est du legacy. J'ai aussi quelques questions fonctionnelles. On voit cela dans la semaine si ça te va @agallou |
vinceAmstoutz
force-pushed
the
feat/events-selector-comparison
branch
2 times, most recently
from
5a568b2 to
d23550f
Compare
agallou
reviewed
Jan 6, 2025
| $comparedEvent = $this->eventActionHelper->getEventById($comparedEventId, false); | ||
| $comparedSerieName = $comparedEvent->getTitle(); | ||
| } else { | ||
| $comparedSerieName = 'n-1'; |
Member
There was a problem hiding this comment.
ici on pourrait se passer de ce elseif, et ne jamais afficher le "n-1", ça permettrais d'être plus lisible en étant toujours explicite et affichant toujours le nom de l'événement comparé (ce qui est maintenant possible vu qu'on a remonté l'appel à $this->forum->obtenirForumPrecedent($id)
stakovicz
force-pushed
the
feat/events-selector-comparison
branch
2 times, most recently
from
51840bd to
8bc7d89
Compare
stakovicz
force-pushed
the
feat/events-selector-comparison
branch
from
8bc7d89 to
3df0e09
Compare
Contributor
|
J'ai finalisé la PR de @vinceAmstoutz . Voici un aperçu du résultat :
|
agallou
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1186 (final part)