-
Notifications
You must be signed in to change notification settings - Fork 2
Version 33.3 #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version 33.3 #111
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # 33.1.0 | ||
|
|
||
| Codemod for upgrading to [AG Grid v33.1.0](https://github.com/ag-grid/ag-grid/releases/tag/v33.1.0) | ||
|
|
||
| ## Usage | ||
|
|
||
| ``` | ||
| npx @ag-grid-devtools/cli migrate --to 33.1.0 | ||
| ``` | ||
|
|
||
| Source code transformations applied by this codemod are specified in [`transforms.ts`](./transforms.ts). | ||
|
|
||
| ## Common tasks | ||
|
|
||
| ### Add a transform | ||
|
|
||
| Option 1: Create a new source code transformation to add to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-transform --release 33.1.0 | ||
| ``` | ||
|
|
||
| Option 2: Add an existing source code transformation to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:include-transform --version 33.1.0 | ||
| ``` | ||
|
|
||
| ### Add a test case | ||
|
|
||
| Create a new unit test scenario for this version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-test --type version --target 33.1.0 | ||
| ``` |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, onTestFinished, test } from 'vitest'; | ||
| import { loadCodemodExampleScenarios } from '../../test/runners/codemod'; | ||
|
|
||
| import codemod from './codemod'; | ||
|
|
||
| const __dirname = dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| describe(codemod, () => { | ||
| const scenariosPath = join(__dirname, './__fixtures__/scenarios'); | ||
| loadCodemodExampleScenarios(scenariosPath, { | ||
| codemod, | ||
| vitest: { describe, expect, test, onTestFinished }, | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { transformFileAst } from '@ag-grid-devtools/codemod-utils'; | ||
| import { | ||
| type Codemod, | ||
| type CodemodInput, | ||
| type CodemodOptions, | ||
| type CodemodResult, | ||
| } from '@ag-grid-devtools/types'; | ||
|
|
||
| import transforms from './transforms'; | ||
|
|
||
| const codemod: Codemod = function codemodV33_1_0( | ||
| file: CodemodInput, | ||
| options: CodemodOptions, | ||
| ): CodemodResult { | ||
| const { path, source } = file; | ||
| const { fs, userConfig } = options; | ||
| return transformFileAst(source, transforms, { | ||
| filename: path, | ||
| fs, | ||
| userConfig, | ||
| }); | ||
| }; | ||
|
|
||
| export default codemod; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { type TransformManifest, type VersionManifest } from '@ag-grid-devtools/types'; | ||
|
|
||
| const transforms: Array<TransformManifest> = []; | ||
|
|
||
| const manifest: VersionManifest = { | ||
| version: '33.1.0', | ||
| codemodPath: 'versions/33.1.0', | ||
| transforms, | ||
| }; | ||
|
|
||
| export default manifest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { type AstCliContext, type AstTransform } from '@ag-grid-devtools/ast'; | ||
|
|
||
| const transforms: Array<AstTransform<AstCliContext>> = []; | ||
|
|
||
| export default transforms; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # 33.2.0 | ||
|
|
||
| Codemod for upgrading to [AG Grid v33.2.0](https://github.com/ag-grid/ag-grid/releases/tag/v33.2.0) | ||
|
|
||
| ## Usage | ||
|
|
||
| ``` | ||
| npx @ag-grid-devtools/cli migrate --to 33.2.0 | ||
| ``` | ||
|
|
||
| Source code transformations applied by this codemod are specified in [`transforms.ts`](./transforms.ts). | ||
|
|
||
| ## Common tasks | ||
|
|
||
| ### Add a transform | ||
|
|
||
| Option 1: Create a new source code transformation to add to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-transform --release 33.2.0 | ||
| ``` | ||
|
|
||
| Option 2: Add an existing source code transformation to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:include-transform --version 33.2.0 | ||
| ``` | ||
|
|
||
| ### Add a test case | ||
|
|
||
| Create a new unit test scenario for this version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-test --type version --target 33.2.0 | ||
| ``` |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, onTestFinished, test } from 'vitest'; | ||
| import { loadCodemodExampleScenarios } from '../../test/runners/codemod'; | ||
|
|
||
| import codemod from './codemod'; | ||
|
|
||
| const __dirname = dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| describe(codemod, () => { | ||
| const scenariosPath = join(__dirname, './__fixtures__/scenarios'); | ||
| loadCodemodExampleScenarios(scenariosPath, { | ||
| codemod, | ||
| vitest: { describe, expect, test, onTestFinished }, | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { transformFileAst } from '@ag-grid-devtools/codemod-utils'; | ||
| import { | ||
| type Codemod, | ||
| type CodemodInput, | ||
| type CodemodOptions, | ||
| type CodemodResult, | ||
| } from '@ag-grid-devtools/types'; | ||
|
|
||
| import transforms from './transforms'; | ||
|
|
||
| const codemod: Codemod = function codemodV33_2_0( | ||
| file: CodemodInput, | ||
| options: CodemodOptions, | ||
| ): CodemodResult { | ||
| const { path, source } = file; | ||
| const { fs, userConfig } = options; | ||
| return transformFileAst(source, transforms, { | ||
| filename: path, | ||
| fs, | ||
| userConfig, | ||
| }); | ||
| }; | ||
|
|
||
| export default codemod; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { type TransformManifest, type VersionManifest } from '@ag-grid-devtools/types'; | ||
|
|
||
| const transforms: Array<TransformManifest> = []; | ||
|
|
||
| const manifest: VersionManifest = { | ||
| version: '33.2.0', | ||
| codemodPath: 'versions/33.2.0', | ||
| transforms, | ||
| }; | ||
|
|
||
| export default manifest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { type AstCliContext, type AstTransform } from '@ag-grid-devtools/ast'; | ||
|
|
||
| const transforms: Array<AstTransform<AstCliContext>> = []; | ||
|
|
||
| export default transforms; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # 33.3.0 | ||
|
|
||
| Codemod for upgrading to [AG Grid v33.3.0](https://github.com/ag-grid/ag-grid/releases/tag/v33.3.0) | ||
|
|
||
| ## Usage | ||
|
|
||
| ``` | ||
| npx @ag-grid-devtools/cli migrate --to 33.3.0 | ||
| ``` | ||
|
|
||
| Source code transformations applied by this codemod are specified in [`transforms.ts`](./transforms.ts). | ||
|
|
||
| ## Common tasks | ||
|
|
||
| ### Add a transform | ||
|
|
||
| Option 1: Create a new source code transformation to add to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-transform --release 33.3.0 | ||
| ``` | ||
|
|
||
| Option 2: Add an existing source code transformation to this codemod release version: | ||
|
|
||
| ``` | ||
| pnpm run task:include-transform --version 33.3.0 | ||
| ``` | ||
|
|
||
| ### Add a test case | ||
|
|
||
| Create a new unit test scenario for this version: | ||
|
|
||
| ``` | ||
| pnpm run task:create-test --type version --target 33.3.0 | ||
| ``` |
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { dirname, join } from 'node:path'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { describe, expect, onTestFinished, test } from 'vitest'; | ||
| import { loadCodemodExampleScenarios } from '../../test/runners/codemod'; | ||
|
|
||
| import codemod from './codemod'; | ||
|
|
||
| const __dirname = dirname(fileURLToPath(import.meta.url)); | ||
|
|
||
| describe(codemod, () => { | ||
| const scenariosPath = join(__dirname, './__fixtures__/scenarios'); | ||
| loadCodemodExampleScenarios(scenariosPath, { | ||
| codemod, | ||
| vitest: { describe, expect, test, onTestFinished }, | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { transformFileAst } from '@ag-grid-devtools/codemod-utils'; | ||
| import { | ||
| type Codemod, | ||
| type CodemodInput, | ||
| type CodemodOptions, | ||
| type CodemodResult, | ||
| } from '@ag-grid-devtools/types'; | ||
|
|
||
| import transforms from './transforms'; | ||
|
|
||
| const codemod: Codemod = function codemodV33_3_0( | ||
| file: CodemodInput, | ||
| options: CodemodOptions, | ||
| ): CodemodResult { | ||
| const { path, source } = file; | ||
| const { fs, userConfig } = options; | ||
| return transformFileAst(source, transforms, { | ||
| filename: path, | ||
| fs, | ||
| userConfig, | ||
| }); | ||
| }; | ||
|
|
||
| export default codemod; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| import { type TransformManifest, type VersionManifest } from '@ag-grid-devtools/types'; | ||
|
|
||
| const transforms: Array<TransformManifest> = []; | ||
|
|
||
| const manifest: VersionManifest = { | ||
| version: '33.3.0', | ||
| codemodPath: 'versions/33.3.0', | ||
| transforms, | ||
| }; | ||
|
|
||
| export default manifest; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { type AstCliContext, type AstTransform } from '@ag-grid-devtools/ast'; | ||
|
|
||
| const transforms: Array<AstTransform<AstCliContext>> = []; | ||
|
|
||
| export default transforms; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -25,7 +25,7 @@ const CODEMOD_TEMPLATE_DIR = join(TEMPLATE_DIR, 'codemod'); | |
|
|
||
| const PROJECT_VERSIONS_DIR = './versions'; | ||
| const MANIFEST_FILENAME = 'manifest.ts'; | ||
| const MANIFEST_TEST_PATH = './lib.test.ts'; | ||
| const MANIFEST_TEST_PATH = './lib.ts'; | ||
|
|
||
| const VARIABLES = [ | ||
| { | ||
|
|
@@ -115,7 +115,7 @@ export default async function task(...args) { | |
| versionManifestPath: stripFileExtension(versionManifestPath), | ||
| versionIdentifier: `v${versionIdentifier}`, | ||
| }); | ||
| await addReleaseToVersionsManifestTests({ manifestTestPath: versionsManifestTestPath, version }); | ||
| // await addReleaseToVersionsManifestTests({ manifestTestPath: versionsManifestTestPath, version }); | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like this file has been updated but the task was not. |
||
| process.stderr.write(`\nCreated codemod version ${green(version)} in ${outputPath}\n`); | ||
| } | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change requested in https://ag-grid.atlassian.net/browse/AG-14637