Relocate "original-" jar to project build directory instead of output directory#3
Open
smartin1018 wants to merge 1 commit intoagaricusb:masterfrom
Open
Relocate "original-" jar to project build directory instead of output directory#3smartin1018 wants to merge 1 commit intoagaricusb:masterfrom
smartin1018 wants to merge 1 commit intoagaricusb:masterfrom
Conversation
Collaborator
|
What does maven shade do? We should have the same behaviour as that |
Author
|
https://stackoverflow.com/questions/4088701/maven-shaded-jar-is-prefixed-with-original-in-the-file-name/8696195 |
Collaborator
|
I think matching maven shade behaviour is correct, it's what is expected by the vast majority of users |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A configuration
Will produce a jar named Foo.jar and original-Foo.jar in the bar/ directory. This PR moves the original-Foo.jar to the appropriate build directory (e.g. target/).
I'm not very familiar with maven conventions, so if there is a better solution that involve project parameters I'd be happy to use that. I personally don't like the idea of filling a specified output directory with previous versions of jars, so this aims to remedy that.