-
Notifications
You must be signed in to change notification settings - Fork 271
[ refactor ] (Re)define (Is)TightApartness and (Is)HeytingCommutativeRing/(Is)HeytingField
#2588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jamesmckinna
wants to merge
36
commits into
agda:master
Choose a base branch
from
jamesmckinna:refactor-heyting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
d171042
refactor: fix #2587
jamesmckinna d07718c
refactor: properties of `HeytingField`, not `HeytingCommutativeRing`
jamesmckinna 7f2f4af
refactor: give `DecSetoid`s the structure of `(Is)TightApartnessRelat…
jamesmckinna 408433d
fix: unsaved commits
jamesmckinna 92f8248
refactor: move property `x-0≈x` to `Algebra.Properties.AbelianGroup`,…
jamesmckinna 55a7384
refactor: deprecate and tighten `import`s
jamesmckinna 3786f55
fix: `CHANGELOG` plus tidying up
jamesmckinna 5da81d0
Merge branch 'master' into refactor-heyting
jamesmckinna 31b51a6
refactor: resolve merge of #2576
jamesmckinna f891093
refactor: another attempt to resolve merge of #2576
jamesmckinna a8d6284
refactor: re-export from `Relation.Binary.Properties.(Dec)Setoid`
jamesmckinna 1f9a4c1
refactor: tighten re-export from `Relation.Binary.Properties.DecSetoid`
jamesmckinna 48bef4a
refactor: re-export from `apartnessRelation` from `HeytingCommutative…
jamesmckinna cdc57d2
fix: better `CHANGELOG`?
jamesmckinna fb2da3e
fix: one last re-export?
jamesmckinna 8dcb5b6
Merge branch 'agda:master' into refactor-heyting
jamesmckinna adebb3c
Merge branch 'master' into refactor-heyting
jamesmckinna df7e404
fix: symbol
jamesmckinna f0f84ef
Merge branch 'master' into refactor-heyting
jamesmckinna 5634375
Merge branch 'master' into refactor-heyting
jamesmckinna 14e7a06
Merge branch 'master' into refactor-heyting
jamesmckinna 24a1d62
Merge branch 'master' into refactor-heyting
jamesmckinna 23125e0
fix: `without-K`
jamesmckinna edef67f
Merge branch 'master' into refactor-heyting
jamesmckinna 3509b3d
add: strong extensionality for `_+_` and `_*_`
jamesmckinna bad5cbb
fix: axiomatisation, but TODO still need to implement for `Data.Ratio…
jamesmckinna a6a4e78
Merge branch 'master' into refactor-heyting
jamesmckinna 0450028
add: `Definitions` and `Consequences` for apartness relations
jamesmckinna 547a9f7
refactor: reflect new module structure
jamesmckinna e790454
refactor: complete `IsHeytingCommutativeRing` axiomatisation
jamesmckinna 92162b9
refactor: complete `IsHeytingCommutativeRing` axiomatisation; tidy up
jamesmckinna 343806e
fix: `whitespace`
jamesmckinna 1616502
fix: unsolved goal
jamesmckinna 4774a2b
Apply suggestion from @jamesmckinna
jamesmckinna 257d8ce
Update version number for deprecations
jamesmckinna 3aa3c80
tweak
jamesmckinna File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ------------------------------------------------------------------------ | ||
| -- The Agda standard library | ||
| -- | ||
| -- Lemmas relating algebraic definitions wrt an apartness. | ||
| ------------------------------------------------------------------------ | ||
|
|
||
| {-# OPTIONS --without-K --safe #-} | ||
|
|
||
| open import Relation.Binary.Core using (Rel) | ||
|
|
||
| module Algebra.Apartness.Consequences | ||
| {a ℓ} {A : Set a} (_#_ : Rel A ℓ) where | ||
|
|
||
| open import Algebra.Core using (Op₁; Op₂) | ||
| open import Algebra.Apartness.Definitions _#_ | ||
| open import Data.Product.Base using (_,_) | ||
| import Data.Sum.Base as Sum | ||
| open import Level using (Level) | ||
| open import Relation.Binary.Definitions | ||
| using (Cotransitive) | ||
|
|
||
| private | ||
| variable | ||
| r : Level | ||
| f : Op₁ A | ||
| _∙_ : Op₂ A | ||
|
|
||
|
|
||
| ------------------------------------------------------------------------ | ||
| -- Cotransitive plus StronglyCongruent₂ implies StronglyExtensional | ||
|
|
||
| cotransitive∧congruent⇒extensional : Cotransitive _#_ → | ||
| StronglyCongruent₂ _∙_ → StronglyExtensional _∙_ | ||
| cotransitive∧congruent⇒extensional | ||
| {_∙_ = _∙_} cotrans cong@(congˡ , congʳ) {y = y} {w = w} xy#wz | ||
| = Sum.map (congʳ y) (congˡ w) (cotrans xy#wz (w ∙ y)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| ------------------------------------------------------------------------ | ||
| -- The Agda standard library | ||
| -- | ||
| -- Properties of operations, relative to an apartness relation | ||
| ------------------------------------------------------------------------ | ||
|
|
||
| {-# OPTIONS --without-K --safe #-} | ||
|
|
||
| open import Relation.Binary.Core using (Rel; _⇒_) | ||
|
|
||
| module Algebra.Apartness.Definitions | ||
| {a ℓ} {A : Set a} -- The underlying set | ||
| (_#_ : Rel A ℓ) -- The underlying apartness | ||
| where | ||
|
|
||
| open import Algebra.Core using (Op₁; Op₂) | ||
| open import Data.Product.Base using (_×_) | ||
| open import Data.Sum.Base using (_⊎_) | ||
| open import Function.Base using (_on_) | ||
|
|
||
|
|
||
| ------------------------------------------------------------------------ | ||
| -- Properties of operations | ||
|
|
||
| module _ (f : Op₁ A) where | ||
|
|
||
| StronglyCongruent₁ : Set _ | ||
| StronglyCongruent₁ = (_#_ on f) ⇒ _#_ | ||
|
|
||
| module _ (_∙_ : Op₂ A) where | ||
|
|
||
| StronglyCongruent₂ : Set _ | ||
| StronglyCongruent₂ = | ||
| (∀ x → StronglyCongruent₁ (x ∙_)) × (∀ z → StronglyCongruent₁ (_∙ z)) | ||
|
|
||
| StronglyExtensional : Set _ | ||
| StronglyExtensional = ∀ {x y w z} → (x ∙ y) # (w ∙ z) → x # w ⊎ y # z | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is a draft, but in the final version it would be good to explain broadly what the refactorings actually are here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest commits, hopefully enough, but not too much, detail now!