Fix potential ReDoS in local-command metadata stripping#729
Open
jsgrrchg wants to merge 2 commits into
Open
Conversation
d0b6cd7 to
e3a7c88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #727.
This replaces the local-command metadata stripping regex with a deterministic scanner over the known SDK local-command marker tags.
The previous implementation used a regex over transcript content to remove marker blocks such as
<command-name>...</command-name>and<local-command-stdout>...</local-command-stdout>. CodeQL flags that pattern as a potential polynomial-time regex on uncontrolled input.The new implementation avoids matching arbitrary content with a regex. It scans only for the five known local-command marker tags and strips complete, well-formed marker blocks while preserving malformed or literal marker-like text.
Covered behavior:
This is intended as a defensive hardening change for the CodeQL finding rather than a claim of a confirmed exploit.
Tests:
npm run test:run -- src/tests/acp-agent.test.ts