Skip to content

Fix broken skills (additionalDirectories) in 0.130.0 #156

Closed
NikolaiSviridov wants to merge 9 commits into
mainfrom
codex-update/0.130.0-skills
Closed

Fix broken skills (additionalDirectories) in 0.130.0 #156
NikolaiSviridov wants to merge 9 commits into
mainfrom
codex-update/0.130.0-skills

Conversation

@NikolaiSviridov
Copy link
Copy Markdown
Collaborator

No description provided.

@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

Why this is done on top of update to 0.130.0? I would expect that we first change skills to new implementation and the do codex update (probably to latest 0.132.0) and check that all tests are still green.

@NikolaiSviridov
Copy link
Copy Markdown
Collaborator Author

@AlexandrSuhinin skills were broken in 0.130.0 and there is a new logic related to skill handling in it (recomended by openai). So, I wanted to merge update 0.130.0 and update to 0.132.0 after.

Can move it to 0.132.0

Comment thread src/CodexAcpClient.ts Outdated
Comment thread src/CodexAcpClient.ts
Comment thread src/CodexAcpClient.ts
Comment thread src/SkillDirectoryParser.ts
Comment thread src/CodexAppServerClient.ts
Comment thread src/CodexAcpClient.ts Outdated
@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

Please add e2e tests if they are missing.

@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

So there is no marketplace API in 0.128.0 version and you're dependent on update to 0.130.0+?

@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

Also I don't really understand if it's a bug, but this review doesn't include all related changes.

Comment thread src/__tests__/CodexACPAgent/e2e/acp-e2e.test.ts Outdated
Comment thread src/CodexAcpServer.ts Outdated
@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

Please rebase this branch on master if marketplace events are supported in 0.128.0.
Reviewing and merging this will be too error-prone otherwise.

@NikolaiSviridov NikolaiSviridov changed the base branch from codex-update/0.130.0 to main May 26, 2026 11:33
@NikolaiSviridov NikolaiSviridov force-pushed the codex-update/0.130.0-skills branch 2 times, most recently from 17f7fee to c7b6f36 Compare May 26, 2026 13:03
@NikolaiSviridov NikolaiSviridov force-pushed the codex-update/0.130.0-skills branch from 1016454 to 3d6097e Compare May 27, 2026 11:22
@AlexandrSuhinin
Copy link
Copy Markdown
Collaborator

I tested this fix, and it actually installs this plugin into CLI, plugin installation isn't virtual, plugin and skills are visible in the CLI.
I believe that this solution doesn't work for us in any case. We are not ready to add plugins in codex TUI. (And if we are ready, we can do it much easier).

I suggest to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants