eval(harbor): trim removed-behavior history from the settings docstring#752
Merged
Conversation
Most of the docstring described what the function no longer does. The rationale for removing the deadline injection belongs in the commit that removed it (02fbcc9), not in a permanent comment on the function that outlived it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #751. Most of
_seed_container_settings's docstring described behavior the function no longer has — the rationale for removing the deadline injection belongs in the commit that removed it (02fbcc91), not in a permanent comment outliving it.Reduces 9 lines of history to one sentence stating the invariant that matters: effort is the only thing seeded, because guidance an eval adapter gives one agent and not another doesn't belong in a comparison.
🤖 Generated with Claude Code