feat: add required field support to InputField and update UI components to respect optionality#391
Merged
Merged
Conversation
…ts to respect optionality
manojbajaj95
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Made OAuth session input fields support an explicit
requiredflag. The scopes field is now marked optional, and the dashboard form respects that flag instead of forcing every session input to be required.Motivation and Context
notion_dcruses dynamic client registration and has no default scopes. The UI was still rendering the empty scopes field as required, which prevented the Continue button from submitting the form. Making scopes optional lets DCR providers without scopes proceed into the login flow.Types of changes