fix: bundle static UI assets into wheel#396
Merged
Merged
Conversation
Hatchling respects .gitignore by default, so the generated src/authsome/ui/web/* assets were excluded from the wheel even though build-ui.sh populates them before uv build runs in CI. - Add force-include for the wheel target (sdist already had this) with the correct installed path (authsome/ui/web, not src/authsome/ui/web) - Remove .gitkeep — build-ui.sh's mkdir -p creates the directory; no placeholder needed - Drop the .gitignore exception for .gitkeep Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
force-include errors during editable installs (uv pip install -e) when src/authsome/ui/web doesn't exist on a fresh checkout, breaking lint and test CI jobs. artifacts bypasses .gitignore for matched files but silently skips missing paths, so editable installs succeed without requiring build-ui.sh to have run first. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitignoreby default, so the generatedsrc/authsome/ui/web/*assets were silently excluded from the published wheel (only the sdist hadforce-includewired up)[tool.hatch.build.targets.wheel.force-include]with the correct installed path (authsome/ui/web, without thesrc/prefix that sdist uses).gitkeepplaceholder —build-ui.shalready runsmkdir -pso no file is needed to keep the directory in gitTest plan
uv build --wheelsucceeds locally after runningscripts/build-ui.shauthsome/ui/web/index.htmland other static assets🤖 Generated with Claude Code