Skip to content

fix(init): squads init works in clean environment#612

Merged
kokevidaurre merged 2 commits intodevelopfrom
solve/issue-610-v2
Mar 24, 2026
Merged

fix(init): squads init works in clean environment#612
kokevidaurre merged 2 commits intodevelopfrom
solve/issue-610-v2

Conversation

@kokevidaurre
Copy link
Contributor

Summary

Clean rebase of #611 onto develop (after #609 merged).

  • Missing provider CLIs treated as warning, not error — users can scaffold first
  • Restored squads list as alias for squads status
  • Dockerfile builds from local source via npm pack
  • Added .dockerignore for fast Docker builds

Testing

All 9 fresh-user Docker test steps pass:

PASS  version, help, init, agents-dir, status, list, catalog-list, doctor, unknown-cmd
=== Results: 9 passed, 0 failed ===

Closes #610

🤖 Generated with Claude Code

- Missing provider CLIs treated as warning, not error — users can
  scaffold first and install providers later
- Restored `squads list` as alias for `squads status`
- Dockerfile builds from local source via npm pack
- Added .dockerignore for fast Docker builds

All 9 fresh-user Docker test steps pass. Closes #610.

Co-Authored-By: Claude <noreply@anthropic.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the squads-cli initialization process and enhances the Docker build workflow. It aims to provide a smoother onboarding experience by making provider CLI checks less restrictive and improving the efficiency of Docker image creation for testing.

Highlights

  • Improved Initialization: Missing provider CLIs are now treated as a warning instead of an error during initialization, allowing users to scaffold first.
  • CLI Command Restoration: The squads list command has been restored as an alias for squads status.
  • Docker Build Enhancements: The Dockerfile for fresh-user tests now builds from local source via npm pack, and a .dockerignore file has been added for faster Docker builds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Tests expected 'missing' status for uninstalled providers, but
the init fix changed this to 'warning' so users can scaffold first.

Co-Authored-By: Claude <noreply@anthropic.com>
@kokevidaurre kokevidaurre merged commit fe1f703 into develop Mar 24, 2026
11 checks passed
@kokevidaurre kokevidaurre deleted the solve/issue-610-v2 branch March 24, 2026 23:33
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a .dockerignore file, re-enables the list command as an alias for status, and changes the checkProviderAuth function to issue a warning instead of an error if a provider's CLI is missing. It also updates the Dockerfile.fresh-user to build and install squads-cli from local source for testing. A suggestion was made to optimize the Docker build process in Dockerfile.fresh-user by leveraging Docker layer caching more effectively for npm ci to improve build performance.

Comment on lines +11 to +12
COPY . .
RUN npm ci && npm run build && npm pack

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve Docker build performance, you can leverage layer caching more effectively. By copying package*.json and running npm ci before copying the rest of the source code, you can avoid reinstalling dependencies on every build unless the package dependency files have changed. This will speed up iterative builds during development and testing.

COPY package*.json ./
RUN npm ci
COPY . .
RUN npm run build && npm pack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant