fix(init): squads init works in clean environment#612
Conversation
- Missing provider CLIs treated as warning, not error — users can scaffold first and install providers later - Restored `squads list` as alias for `squads status` - Dockerfile builds from local source via npm pack - Added .dockerignore for fast Docker builds All 9 fresh-user Docker test steps pass. Closes #610. Co-Authored-By: Claude <noreply@anthropic.com>
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Tests expected 'missing' status for uninstalled providers, but the init fix changed this to 'warning' so users can scaffold first. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a .dockerignore file, re-enables the list command as an alias for status, and changes the checkProviderAuth function to issue a warning instead of an error if a provider's CLI is missing. It also updates the Dockerfile.fresh-user to build and install squads-cli from local source for testing. A suggestion was made to optimize the Docker build process in Dockerfile.fresh-user by leveraging Docker layer caching more effectively for npm ci to improve build performance.
| COPY . . | ||
| RUN npm ci && npm run build && npm pack |
There was a problem hiding this comment.
To improve Docker build performance, you can leverage layer caching more effectively. By copying package*.json and running npm ci before copying the rest of the source code, you can avoid reinstalling dependencies on every build unless the package dependency files have changed. This will speed up iterative builds during development and testing.
COPY package*.json ./
RUN npm ci
COPY . .
RUN npm run build && npm pack
Summary
Clean rebase of #611 onto develop (after #609 merged).
squads listas alias forsquads statusnpm pack.dockerignorefor fast Docker buildsTesting
All 9 fresh-user Docker test steps pass:
Closes #610
🤖 Generated with Claude Code