fix(manager): reject MCP options during runtime switches - #1053
fix(manager): reject MCP options during runtime switches#1053RerankerGuo wants to merge 1 commit into
Conversation
📊 CI Metrics ReportSummary
By Role
Per-Test Breakdown
Trends✅ 1 test(s) improved (fewer LLM calls) Generated by HiClaw CI on 2026-07-16 12:34:56 UTC |
|
This fixes a real runtime-switch contract mismatch: MCP authorization cannot be forwarded through hiclaw update worker and must remain a separate operation. The current blocker is the conflict with the latest main branch. Please rebase, keep the diff limited to the wrapper, agent-facing documentation, focused test, and current changelog entry, then rerun manager/tests/test-update-worker-runtime.sh. Once the branch is clean and the focused test passes, this should be straightforward to review. |
|
Rebuilt this PR on current The runtime-switch path now rejects Verification:
|
cc4e881 to
2392c08
Compare
Summary
--mcp-serverswith--runtimebefore invoking the controller CLIRoot cause
update-worker-config.shexposes--mcp-serversfor its in-place authorization path, but the runtime-switch branch forwarded the same option tohiclaw update worker. The Go CLI does not implement that flag and directs MCP server updates through a separate flow, so the documented combined command could not succeed.Validation
manager/tests/test-update-worker-runtime.sh(4/4 assertions)bash -nfor the changed script and testhiclaw update worker --helpcontract checkgit diff --check