fix(core): Fix MediaUtils parse path extension#981
Merged
LearningGp merged 9 commits intoagentscope-ai:mainfrom Mar 27, 2026
Merged
fix(core): Fix MediaUtils parse path extension#981LearningGp merged 9 commits intoagentscope-ai:mainfrom
LearningGp merged 9 commits intoagentscope-ai:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
LearningGp
requested changes
Mar 24, 2026
agentscope-core/src/main/java/io/agentscope/core/formatter/MediaUtils.java
Show resolved
Hide resolved
guanxuc
force-pushed
the
fix-MediaUtils-977
branch
from
ffa1c12 to
02b8a2d
Compare
Contributor
Author
|
@LearningGp Thanks for your review and good suggestion! I have fixed the code by strip the path. |
LearningGp
requested changes
Mar 26, 2026
agentscope-core/src/main/java/io/agentscope/core/formatter/MediaUtils.java
Outdated
Show resolved
Hide resolved
guanxuc
force-pushed
the
fix-MediaUtils-977
branch
from
02b8a2d to
6ab3ac4
Compare
Contributor
Author
|
@LearningGp I have changed the parse code logic. Use |
LearningGp
requested changes
Mar 27, 2026
agentscope-core/src/main/java/io/agentscope/core/formatter/MediaUtils.java
Outdated
Show resolved
Hide resolved
agentscope-core/src/test/java/io/agentscope/core/formatter/MediaUtilsTest.java
Show resolved
Hide resolved
guanxuc
force-pushed
the
fix-MediaUtils-977
branch
from
ff3076e to
80ece24
Compare
Contributor
Author
|
@LearningGp Thanks for your review, I've cleaned up the code completely. |
LearningGp
reviewed
Mar 27, 2026
agentscope-core/src/main/java/io/agentscope/core/formatter/MediaUtils.java
Outdated
Show resolved
Hide resolved
guanxuc
force-pushed
the
fix-MediaUtils-977
branch
from
80ece24 to
6800fc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.11
Description
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)