Refactor: Replace monolithic config with modular ClientConfig and ServerConfig#36
Merged
philippschroeppel merged 3 commits intoagentsea:mainfrom Jul 10, 2025
Merged
Conversation
Collaborator
|
@philippschroeppel Can you please integrate this change as well? a243b99 It solves #8 You should be able to cherry-pick this commit to your branch. It will also give you a way to test your changes a bit more. |
Collaborator
Author
|
@ionicsolutions Unfortunately I was not able to cherry-pick the commit. I think the most elegant / idiomatic approach to enforcing unique server names (cf. #8) is to store client-side server configs in a hashmap. |
ionicsolutions
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the monolithic
config.rswith a modular configuration system that separates client-side and server-side concerns. The modular configuration is based on #10,Changes
GlobalConfig→ClientConfig,ServerConfig→ClientServerConfigConfigintoServerConfig,RedisConfig,KafkaConfig,DatabaseConfig,ServerAuthConfig,TailscaleConfigCONFIG.auth_server→SERVER_CONFIG.auth.urlRedisConfig.get_url()method for cleaner URL constructionKafkaConfigwith proper timeout parsingSERVER_CONFIGstatic instance for server-side configBreaking Changes
GlobalConfig→ClientConfigCONFIG→SERVER_CONFIGfor server-side usageauth_server→auth.url)Testing