fix: Ensure we set ports / addresses while waiting for pod IPs by lacroixthomas · Pull Request #4095 · agones-dev/agones

lacroixthomas · 2025-01-21T19:42:13Z

What type of PR is this?
/kind bug

What this PR does / Why we need it:
Currently, the gameserver wait that the Pod IPs are populated before setting the ports and addresses

This seems to be blocking for a moment, we already have the ports and addresses from the node available, we should set them and keep waiting for the pod IPs until ready to move to GameServerStateScheduled (following this diagram: https://agones.dev/site/docs/reference/gameserver/#gameserver-state-diagram)

Which issue(s) this PR fixes:
Closes #3960

Special notes for your reviewer:

lacroixthomas · 2025-01-21T21:14:13Z

Hello @0xaravindh
I've seen that you commented /gcbrun on my other PR which triggered the pipeline
Could you do it again for this one ? For me to do some manual testing with the new build 😄

0xaravindh · 2025-01-22T03:41:28Z

/gcbrun

agones-bot · 2025-01-22T04:10:36Z

Build Failed 😭

Build Id: 1ce69844-72da-4b87-b2ca-e583f2e40f32

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

0xaravindh · 2025-01-22T05:46:55Z

/gcbrun

agones-bot · 2025-01-22T06:44:18Z

Build Failed 😭

Build Id: 396cc119-9ba3-48a5-b9d2-fe41781fda60

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

pkg/gameservers/controller.go

lacroixthomas · 2025-01-22T17:10:34Z

@0xaravindh
I'm sorry to bother you again, can you re-comment for the pipeline ?

Or if there is a way to run it locally maybe ? Seems that it's the submit-e2e-test-cloud-build that is failing
Maybe it changed, but I previously be able to just push to run the pipeline, is it because it's in draft ?

vicentefb · 2025-01-22T17:11:48Z

/gcbrun

agones-bot · 2025-01-22T17:17:43Z

Build Failed 😭

Build Id: c41e2f02-f528-4dee-ae6e-3e65d87da1fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

vicentefb · 2025-01-22T17:22:41Z

Also, this is the guide to build it and test it locally https://github.com/googleforgames/agones/blob/main/build/README.md#testing-and-building

vicentefb · 2025-01-22T17:25:03Z

It currently fails on lint errors. Those can be caught by running make lint https://github.com/googleforgames/agones/blob/bebe915cb4ccc83a8bb85d5ba106602ba47565c5/build/Makefile#L497

lacroixthomas · 2025-01-22T17:26:44Z

Also, this is the guide to build it and test it locally https://github.com/googleforgames/agones/blob/main/build/README.md#testing-and-building

Thanks ! I'm gonna have a look to run that locally

lacroixthomas · 2025-01-22T17:36:54Z

Alright, I ran both the e2e that were failing TestSuperTuxKartGameServerReady and TestCreateConnect, they are now passing locally, and also fixed the linter issue and checked with make lint, it should be all good now 😄

vicentefb · 2025-01-22T17:49:47Z

/gcbrun

agones-bot · 2025-01-22T17:58:38Z

Build Failed 😭

Build Id: af9e5b00-fe91-42ac-b238-9f0b49b64aab

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

vicentefb · 2025-01-22T18:16:20Z

/gcbrun

agones-bot · 2025-01-22T19:21:18Z

Build Succeeded 🥳

Build Id: bd45a8dc-7e0a-484b-a8ab-6d1f6f1b74e1

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.47.0-dev-ace3147
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.47.0-dev-ace3147
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.47.0-dev-ace3147-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.47.0-dev-ace3147
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.47.0-dev-ace3147
Linux C++ SDK (build): agonessdk-1.47.0-dev-ace3147-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.47.0-dev-ace3147.zip

A preview of the website (the last 30 builds are retained):

https://ace3147-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-ace3147

0xaravindh · 2025-01-27T10:18:39Z

/gcbrun

agones-bot · 2025-01-27T11:22:17Z

Build Succeeded 🥳

Build Id: 85654e2a-42c4-4649-8bcc-4032850ceaeb

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.47.0-dev-329bf81
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.47.0-dev-329bf81
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.47.0-dev-329bf81-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.47.0-dev-329bf81
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.47.0-dev-329bf81
Linux C++ SDK (build): agonessdk-1.47.0-dev-329bf81-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.47.0-dev-329bf81.zip

A preview of the website (the last 30 builds are retained):

https://329bf81-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.47.0-dev-329bf81

agones-bot · 2025-06-04T00:32:28Z

Build Failed 😭

Build Id: 81406e21-5e51-4172-8f8a-87a984964d65

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-06-04T01:06:30Z

Build Failed 😭

Build Id: eb63f4da-9f02-40a2-9217-1ad3723de503

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-06-10T22:29:16Z

Build Succeeded 🥳

Build Id: b6bb2246-282d-4c58-95f6-4eea8baaa410

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-8d8c27c
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-8d8c27c
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-8d8c27c-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-8d8c27c
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-8d8c27c
Linux C++ SDK (build): agonessdk-1.50.0-dev-8d8c27c-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-8d8c27c.zip

A preview of the website (the last 30 builds are retained):

https://8d8c27c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-8d8c27c

agones-bot · 2025-06-13T11:12:04Z

Build Succeeded 🥳

Build Id: f137c67f-70ce-4cb0-80d7-e9a013de56b2

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.50.0-dev-fd467fd
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.50.0-dev-fd467fd
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.50.0-dev-fd467fd-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.50.0-dev-fd467fd
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.50.0-dev-fd467fd
Linux C++ SDK (build): agonessdk-1.50.0-dev-fd467fd-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.50.0-dev-fd467fd.zip

A preview of the website (the last 30 builds are retained):

https://fd467fd-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.50.0-dev-fd467fd

agones-bot · 2025-08-12T11:39:46Z

Build Failed 😭

Build Id: 46db9ff4-a090-4f72-aec9-de503acaa727

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-08-17T00:44:29Z

Build Succeeded 🥳

Build Id: 2121ffc7-2975-405d-b802-f7b9c2d8562c

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.52.0-dev-a491f30
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.52.0-dev-a491f30
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.52.0-dev-a491f30-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.52.0-dev-a491f30
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.52.0-dev-a491f30
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.52.0-dev-a491f30
Linux C++ SDK (build): agonessdk-1.52.0-dev-a491f30-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.52.0-dev-a491f30.zip

A preview of the website (the last 30 builds are retained):

https://a491f30-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-a491f30

markmandel · 2025-09-07T18:34:19Z

I've totally forgotten where we are on this PR? 😄

lacroixthomas · 2025-09-07T21:58:41Z

Same here, I'll have a look, kind of forgot it, I think it was ready to go, but will need to double check first 😅

lacroixthomas · 2025-09-11T22:53:58Z

Will try to have a look at the end of the week, it's on my list*

lacroixthomas · 2025-09-12T22:23:43Z

@markmandel
I was checking my last changes, seems to be ready
It adds the podIP if it's available on:

syncGameServerCreatingState
syncGameServerStartingState
syncGameServerRequestReadyState

And also if it's not getting to be updated from the sync (because of other error) and the podIP is available, it does the update (syncGameServerRequestReadyState)

I'll wait for the e2e to pass, but it should be good for review 😄

agones-bot · 2025-09-13T00:04:59Z

Build Failed 😭

Build Id: a7de9010-6e6e-49dd-8230-b7955fae8866

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-09-17T20:24:40Z

Build Succeeded 🥳

Build Id: 9ffa9191-4010-4dcb-8e2d-f165949dfa41

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-d6293c6
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-d6293c6
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-d6293c6-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-d6293c6
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-d6293c6
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-d6293c6
Linux C++ SDK (build): agonessdk-1.53.0-dev-d6293c6-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-d6293c6.zip

A preview of the website (the last 30 builds are retained):

https://d6293c6-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-d6293c6

agones-bot · 2025-10-19T21:44:07Z

Build Failed 😭

Build Id: 54f0d4e0-6499-499d-9464-ce5e066e6c39

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-20T18:03:13Z

Build Failed 😭

Build Id: 53c338f6-eaa5-4769-a298-16e8ed0ff730

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2025-10-21T06:45:54Z

Build Succeeded 🥳

Build Id: 52c78d97-e31a-4c24-a6a0-ea2c28019d05

The following development artifacts have been built, and will exist for the next 30 days:

image: us-docker.pkg.dev/agones-images/ci/agones-controller:1.53.0-dev-010a278
image: us-docker.pkg.dev/agones-images/ci/agones-extensions:1.53.0-dev-010a278
image: us-docker.pkg.dev/agones-images/ci/agones-sdk:1.53.0-dev-010a278-linux
image: us-docker.pkg.dev/agones-images/ci/agones-ping:1.53.0-dev-010a278
image: us-docker.pkg.dev/agones-images/ci/agones-allocator:1.53.0-dev-010a278
image: us-docker.pkg.dev/agones-images/ci/agones-processor:1.53.0-dev-010a278
Linux C++ SDK (build): agonessdk-1.53.0-dev-010a278-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.53.0-dev-010a278.zip

A preview of the website (the last 30 builds are retained):

https://010a278-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4095/head:pr_4095 && git checkout pr_4095
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.53.0-dev-010a278

lacroixthomas · 2025-10-21T14:52:25Z

Seems that the CLA was not signed by Ka****dh@google.com ? Could that be that he updated my PR with the main branch but didn't signed the CLA ? 🤔

markmandel · 2025-10-27T19:35:23Z

pkg/gameservers/controller.go

+	if podIPUpdated {
+		// defer the update of the GameServer until the end of this function
+		// in case there is no gs state update and the podIP is available and populated
+		defer func(gs *agonesv1.GameServer, alreadyUpdated *bool) {


This freaks me out a bunch 😆 - but you still end up with a double update, which seems unnecessary.

The way I wanted to this work was that whenever the Pod IP is updated, then the GameServer gets updated - unless it's already captured in an existing status update.

We shouldn't need to have a double updated if it's already seen inside one of these status change sync functions.

markmandel · 2026-03-02T19:25:10Z

Hope you don't mind - I have a pass at this in the works. Ended up being a bit easier than trying to explain what I was thinking.

lacroixthomas · 2026-03-02T21:04:18Z

Hope you don't mind - I have a pass at this in the works. Ended up being a bit easier than trying to explain what I was thinking.

Oh yeah no, please got for it, I totally forgot about this one 😄

github-actions bot added kind/bug These are bugs. size/S labels Jan 21, 2025

lacroixthomas changed the title ~~fix: ensure we set ports addresses while waiting for pod IPs~~ fix: Ensure we set ports / addresses while waiting for pod IPs Jan 21, 2025

miai10 reviewed Jan 22, 2025

View reviewed changes

pkg/gameservers/controller.go Outdated Show resolved Hide resolved

miai10 reviewed Jan 22, 2025

View reviewed changes

pkg/gameservers/controller.go Show resolved Hide resolved

lacroixthomas marked this pull request as ready for review January 23, 2025 23:19

lacroixthomas added 5 commits January 25, 2025 12:13

fix: ensure we set ports addresses while waiting for pod IPs

5944adc

fix: update unit tests

fc9b8d2

fix: ensure podIPs are also set on ready if called before controller

70cd30f

fix: ensure podIPs are also set on ready if called before controller

3e1a602

fix: ensure we set the new PodIPs if they are present

329bf81

lacroixthomas force-pushed the bugfixes/delays-awaiting-pod-ips branch from ace3147 to 329bf81 Compare January 25, 2025 17:14

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

23f928d

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

8d8c27c

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

fd467fd

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

a6af646

lacroixthomas mentioned this pull request Aug 13, 2025

Approver request #4245

Closed

5 tasks

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

a491f30

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

5c45723

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

d6293c6

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

aabd5fb

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

0b66d2f

Merge branch 'main' into bugfixes/delays-awaiting-pod-ips

010a278

markmandel reviewed Oct 27, 2025

View reviewed changes

Conversation

lacroixthomas commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lacroixthomas commented Jan 21, 2025

Uh oh!

0xaravindh commented Jan 22, 2025

Uh oh!

agones-bot commented Jan 22, 2025

Uh oh!

0xaravindh commented Jan 22, 2025

Uh oh!

agones-bot commented Jan 22, 2025

Uh oh!

Uh oh!

Uh oh!

lacroixthomas commented Jan 22, 2025

Uh oh!

vicentefb commented Jan 22, 2025

Uh oh!

agones-bot commented Jan 22, 2025

Uh oh!

vicentefb commented Jan 22, 2025

Uh oh!

vicentefb commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lacroixthomas commented Jan 22, 2025

Uh oh!

lacroixthomas commented Jan 22, 2025

Uh oh!

vicentefb commented Jan 22, 2025

Uh oh!

agones-bot commented Jan 22, 2025

Uh oh!

vicentefb commented Jan 22, 2025

Uh oh!

agones-bot commented Jan 22, 2025

Uh oh!

0xaravindh commented Jan 27, 2025

Uh oh!

agones-bot commented Jan 27, 2025

Uh oh!

agones-bot commented Jun 4, 2025

Uh oh!

agones-bot commented Jun 4, 2025

Uh oh!

agones-bot commented Jun 10, 2025

Uh oh!

agones-bot commented Jun 13, 2025

Uh oh!

agones-bot commented Aug 12, 2025

Uh oh!

agones-bot commented Aug 17, 2025

Uh oh!

markmandel commented Sep 7, 2025

Uh oh!

lacroixthomas commented Sep 7, 2025

Uh oh!

lacroixthomas commented Sep 11, 2025

Uh oh!

lacroixthomas commented Sep 12, 2025

Uh oh!

agones-bot commented Sep 13, 2025

Uh oh!

agones-bot commented Sep 17, 2025

Uh oh!

agones-bot commented Oct 19, 2025

Uh oh!

agones-bot commented Oct 20, 2025

Uh oh!

agones-bot commented Oct 21, 2025

Uh oh!

lacroixthomas commented Oct 21, 2025

Uh oh!

markmandel Oct 27, 2025

Choose a reason for hiding this comment

Uh oh!

markmandel commented Mar 2, 2026

Uh oh!

lacroixthomas commented Jan 21, 2025 •

edited

Loading

vicentefb commented Jan 22, 2025 •

edited

Loading