Open
Conversation
wc0sby
reviewed
Sep 3, 2018
wc0sby
left a comment
There was a problem hiding this comment.
Easy to follow, but there are a few items to address. The biggest drawback at the moment is your isValidMove function. It does not return. Also, when submitting final work, try to remove outstanding console logs for readability.
|
|
||
| theBs.forEach((item, index) => { | ||
| let theBlacks = new Checker('black'); | ||
| let coordinate1 = theBs[index]; |
There was a problem hiding this comment.
Since you are using forEach, you can just call the item parameter.
| this.grid[coordinate1[0]][coordinate1[1]] = theBlacks; | ||
| }); | ||
|
|
||
| console.log(this.checkers.length); |
There was a problem hiding this comment.
Try to remove console logs from your code after debugging for cleanliness
|
|
||
|
|
||
|
|
||
| isValidMove(whatPiece, moveTo) { |
There was a problem hiding this comment.
This function needs a return in order to complete your moveChecker function. This is currently just reassigning checker positions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint Rubric
This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.
Checkpoint 1
Checkpoint 2
Checkpoint 3