Skip to content

Class10 checkers#13

Open
aguevara1 wants to merge 8 commits intogh-pagesfrom
class10-checkers
Open

Class10 checkers#13
aguevara1 wants to merge 8 commits intogh-pagesfrom
class10-checkers

Conversation

@aguevara1
Copy link
Owner

Checkpoint Rubric

This is the rubric that your instructor will use to grade your checkpoints. Please do not edit.

Checkpoint 1

  • All tests passed: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript: 30 points

Checkpoint 2

  • The application works as it should: 40 points
  • Proper use of documentation (commenting on code): 15 points
  • Properly indented code: 15 points
  • Demonstrated effective use of JavaScript and the DOM API: 30 points

Checkpoint 3

  • Use of React: 25 points
  • Accesses an API: 25 points
  • Proper use of documentation (commenting on code): 25 points
  • The application functions as it should: 25 points

Copy link

@wc0sby wc0sby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to follow, but there are a few items to address. The biggest drawback at the moment is your isValidMove function. It does not return. Also, when submitting final work, try to remove outstanding console logs for readability.


theBs.forEach((item, index) => {
let theBlacks = new Checker('black');
let coordinate1 = theBs[index];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you are using forEach, you can just call the item parameter.

this.grid[coordinate1[0]][coordinate1[1]] = theBlacks;
});

console.log(this.checkers.length);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to remove console logs from your code after debugging for cleanliness




isValidMove(whatPiece, moveTo) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function needs a return in order to complete your moveChecker function. This is currently just reassigning checker positions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants