forked from AustinCodingAcademy/javascript-workbook
-
Notifications
You must be signed in to change notification settings - Fork 0
init push #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aguevara1
wants to merge
1
commit into
gh-pages
Choose a base branch
from
class4-pigLatin2
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
init push #5
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,23 +7,81 @@ const rl = readline.createInterface({ | |
| output: process.stdout | ||
| }); | ||
|
|
||
| //global variables | ||
| const theVowels = ['a', 'e', 'i', 'o', 'u']; | ||
| let doesItContainVowel=false; | ||
|
|
||
| function pigLatin(word) { | ||
| //ascii keyboard lowercase values a-z are 97 to 122 | ||
| // compare and check for values of the characters in string | ||
| // to not be outside of this range, if not in range return false | ||
| const isValid = (word) => { | ||
| for(const letter of word){ | ||
| if(letter <'a' || letter >'z'){ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Refactor this and test the true first. If you return true first, the false is implicit. Also, you could shorten even further. Really neat trick here, btw |
||
| return false; | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| // Your code here | ||
| // put string into a new array with split() | ||
| // forEach loop to check each vowel to see if returns a valid indexOf | ||
| // if finds valid index in firstArr, will push index number to uptoVowel array | ||
| // and assign global variable doesItContainVowel to true | ||
| const findVowelIndex = (anotherWord) => { | ||
| const uptoVowel = []; | ||
| const firstArr = anotherWord.split(''); | ||
| doesItContainVowel=false; | ||
|
|
||
| theVowels.forEach( (element) => { | ||
| if(firstArr.indexOf(element) !== -1){ | ||
| uptoVowel.push(firstArr.indexOf(element)); | ||
| doesItContainVowel=true; | ||
| } | ||
| }); | ||
| // sort arranges smallest index number at the beginning of array | ||
| // returns the index number to parent function | ||
| uptoVowel.sort() | ||
| return uptoVowel[0]; | ||
| } | ||
|
|
||
| //function will return word in piglatin | ||
| //will trim white space and make lowercase then call function isValid | ||
| //to make sure user entered valid input | ||
| const pigLatin = (word) => { | ||
|
|
||
| const wordTrimmedLowerCase = word.trim().toLowerCase(); | ||
| if (wordTrimmedLowerCase && isValid(wordTrimmedLowerCase)) { | ||
|
|
||
| //findVowelIndex() will return the index of first vowel | ||
| const theVowelIndex=findVowelIndex(wordTrimmedLowerCase); | ||
|
|
||
| // if global variable doesItContainVowel was set to false | ||
| if(doesItContainVowel===false){ | ||
| return "Enter a regular word!!"; | ||
| }else{ | ||
| if(theVowelIndex===0){ | ||
| return wordTrimmedLowerCase+'yay'; | ||
| }else{ | ||
| return `${wordTrimmedLowerCase.substr(theVowelIndex)}${wordTrimmedLowerCase.substr(0,theVowelIndex)}ay`; | ||
| } | ||
| } | ||
|
|
||
| } else { | ||
| return "Enter a word"; | ||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
||
| function getPrompt() { | ||
| rl.question('word ', (answer) => { | ||
| console.log( pigLatin(answer) ); | ||
| console.log(pigLatin(answer)); | ||
| getPrompt(); | ||
| }); | ||
| } | ||
|
|
||
| // Tests | ||
|
|
||
| // Tests | ||
| if (typeof describe === 'function') { | ||
|
|
||
| describe('#pigLatin()', () => { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this in the global scope is dangerous as it can be overwritten. Think of another way to write your code so that this accessible only when needed.