Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Test & Lint SummaryCommands:
Test stats: passed 2, failed 0, skipped 0 (buf lint, buf build) |
Summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean, well-structured OpenAPI schema that faithfully mirrors the proto definition and follows team/v1 conventions. All routes, schemas, shared components, and CI workflow steps are correctly implemented per issue #21.
One nit left inline — otherwise LGTM.
| get: | ||
| tags: [Secrets] | ||
| summary: List secrets | ||
| parameters: |
There was a problem hiding this comment.
[nit] The secretProviderId query parameter is missing a description. The team/v1 convention includes descriptions for domain-specific filters (e.g. q in agents). Adding something like description: Filter by secret provider UUID. would improve discoverability for API consumers.
Summary
Testing
Closes #21