Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Summary
Test & Lint SummaryCommands
Test stats: passed 0, failed 0, skipped 0 (lint/build only; no test counts reported) Lint status: buf lint clean; spectral lint warnings only (0 errors). |
noa-lucent
left a comment
There was a problem hiding this comment.
Proto definition is clean, well-structured, and faithfully implements the spec from #28. Package naming, field numbering, go_package, and message layout all follow existing repo conventions and Buf STANDARD lint rules.
One nit left about adding per-RPC doc comments for discoverability — not blocking.
LGTM.
| // AuthorizationService is a thin gRPC proxy to OpenFGA. | ||
| // It mirrors the OpenFGA runtime API and injects store/model IDs. | ||
| service AuthorizationService { | ||
| rpc Check(CheckRequest) returns (CheckResponse); |
There was a problem hiding this comment.
[nit] The issue spec includes a short description for each RPC (e.g. "Can identity X perform relation Y on resource Z? Returns allowed: bool"). Adding per-RPC doc comments would improve discoverability and is consistent with the pattern in chat.proto. Not blocking, but recommended.
// Can identity X perform relation Y on resource Z?
rpc Check(CheckRequest) returns (CheckResponse);
// Multiple checks in a single call. Each check has a correlation_id
// for matching responses.
rpc BatchCheck(BatchCheckRequest) returns (BatchCheckResponse);
...
Summary
Testing
Refs #28