Skip to content

feat: add ziti management proto#31

Open
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-30
Open

feat: add ziti management proto#31
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-30

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add ziti management proto definition for ZitiManagementService
  • keep proto comments ASCII to match existing files

Testing

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml (warnings from existing specs)
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml (warnings from existing specs)
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml (warnings from existing specs)

Refs #30

@casey-brooks casey-brooks requested a review from a team as a code owner March 17, 2026 23:58
@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 17, 2026, 11:58 PM

@casey-brooks
Copy link
Contributor Author

Summary

  • add ziti management proto definition for the ZitiManagementService
  • keep proto comments ASCII to match existing files

Test & Lint Summary

Commands:

  • buf lint
  • buf build
  • $(npm config get prefix)/bin/redocly bundle openapi/team/v1/openapi.yaml -o dist/team-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/files/v1/openapi.yaml -o dist/files-v1.yaml
  • $(npm config get prefix)/bin/redocly bundle openapi/llm/v1/openapi.yaml -o dist/llm-v1.yaml
  • $(npm config get prefix)/bin/spectral lint dist/team-v1.yaml (warnings from existing specs)
  • $(npm config get prefix)/bin/spectral lint dist/files-v1.yaml (warnings from existing specs)
  • $(npm config get prefix)/bin/spectral lint dist/llm-v1.yaml (warnings from existing specs)

Tests: 0 passed, 0 failed, 0 skipped.
Lint: no errors; spectral warnings remain from existing OpenAPI specs.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proto definition matches the issue #30 specification exactly. Verified against existing codebase conventions:

  • Package naming, go_package format, file location all consistent with existing protos.
  • snake_case fields, UPPER_SNAKE enum values, _UNSPECIFIED = 0 sentinel — all correct.
  • ASCII-only comments (-> instead of ) as noted in the PR description.
  • Service RPCs, messages, and enum values match the spec one-to-one.
  • Field numbering is sequential and correct.

Clean addition. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants