Open
Conversation
emerson-gray
force-pushed
the
container-terminal-architecture
branch
from
7181fb7 to
70ce8ae
Compare
emerson-gray
changed the title
emerson-gray
force-pushed
the
container-terminal-architecture
branch
2 times, most recently
from
f07eaee to
c71970b
Compare
- Add architecture/terminal-proxy.md — standalone WebSocket service for interactive terminal access to workload containers - Terminal Proxy has a single responsibility: bridge WebSocket sessions to Runner Exec RPC via OpenZiti. No workload discovery methods. - Documents: WebSocket protocol (JSON messages), flow diagram, exec configuration, authentication, authorization, OpenZiti policies, ingress, configuration - Add Terminal Proxy to system-overview.md (component summary, diagram, repository map) and README.md - Add open question: Workload Discovery and Runner Routing — where does container discovery for the UI live, and how does the Terminal Proxy route to the correct runner instance
emerson-gray
force-pushed
the
container-terminal-architecture
branch
from
c71970b to
6f4bec7
Compare
Terminal Proxy now queries the Runners service (GetWorkload) to resolve which runner hosts the target workload before dialing via OpenZiti. Changes: - Add 'Runner resolution' responsibility - Add Runners Service participant to connection flow diagram - Add GetWorkload call before shell detection in the flow - Add runner resolution paragraph in Workload Container Selection - Add RUNNERS_SERVICE_ADDRESS to configuration - Update internal calls to include Runners
vitramir
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the Terminal Proxy — a standalone service for interactive terminal access to workload containers. Single responsibility: bridge WebSocket sessions to Runner
ExecRPC via OpenZiti.New file:
architecture/terminal-proxy.mdWebSocket endpoint —
/terminal/ws?workloadId={workloadId}&containerId={containerId}input,resize,ping,close(client→server) /output,status,error,pong(server→client)containerIdtargets a specific container within the workload podInfrastructure:
agyn.dev/terminal/)net/http,nhooyr.io/websocket, OpenZiti SDKChanges to existing docs
architecture/system-overview.md: Terminal Proxy added to component diagram, component summary table, and repository mapREADME.md: Terminal Proxy added to architecture docs tableopen-questions.md: Added "Workload Discovery and Runner Routing" — where does container discovery for the UI live, and how does the Terminal Proxy route to the correct runner instance when multiple runners existRelated