Conversation
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
noa-lucent
left a comment
There was a problem hiding this comment.
The overall structure is solid and follows the existing ArgoCD application / Helm values patterns well. The vendored module, FGA model, outputs, variables, and lock file additions all look correct.
Three issues to address before merge:
- Naming inconsistency (
authorization_image_tag→resolved_authorization_image_tag): breaks the established convention used by every other image-tag local. - Duplicate provider declaration: the
provider "openfga"block in the child module duplicates the root module's provider config, creating two independent provider instances. - Orphaned variable: removing the duplicate provider from the module makes
openfga_api_urlunused — clean it up from both the module variables and the module call.
cb844cc to
f140028
Compare
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
noa-lucent
left a comment
There was a problem hiding this comment.
All three issues from the previous review are resolved:
- ✅ Local renamed to
resolved_authorization_image_tag— consistent with the existing convention. - ✅ Duplicate
provider "openfga"block removed from the child module — provider now inherited from root. - ✅ Orphaned
openfga_api_urlvariable and module argument cleaned up.
No new issues found. LGTM — good to merge.
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
|
Summary:
Note: Terraform keeps the OpenFGA provider in the lock file because the remote module depends on it. |
noa-lucent
left a comment
There was a problem hiding this comment.
The refactor from a vendored module to a remote reference (github.com/agynio/authorization//terraform?ref=v0.1.1) is a good improvement — it keeps the FGA model and store logic in the authorization repo where it belongs.
All previous review feedback remains addressed. The new changes are clean:
- Provider config correctly lives only in the remote module now (no duplication).
- External URL for the Terraform provider and internal URL for the Helm chart are correctly separated.
SSL_CERT_FILEexport is placed at the right point in the apply sequence.- Outputs, variables, ArgoCD app resource, and lock file are all consistent.
Two minor suggestions added (version-pinning comment, SSL_CERT_FILE comment) — neither blocks merge.
LGTM.
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
|
Summary:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Previous review feedback is fully addressed — both threads resolved. The module lockstep comment was added, and the SSL_CERT_FILE export was replaced with a proper CA installation script.
The new install-ca-cert.sh is well-structured overall — proper argument parsing, boundary validation, sudo handling, idempotency, and interactive/non-interactive modes. Two duplications to clean up before merge:
- Alpine + Debian/Ubuntu branches are identical — merge into one condition.
- Confirmation prompt block is duplicated between Linux and macOS paths — extract a
confirm_or_aborthelper.
The Terraform changes (module, ArgoCD app, outputs, variables, lock file) remain clean and correct.
Test & Lint Summary
Tests: passed (1), failed (0), skipped (0) |
noa-lucent
left a comment
There was a problem hiding this comment.
Both issues from the last review are resolved:
- ✅ Alpine merged into the Debian/Ubuntu branch — single condition, no duplication.
- ✅
confirm_or_aborthelper extracted — prompt logic defined once, called from both Linux and macOS paths.
The install-ca-cert.sh script is now clean and well-structured. All prior review threads across all iterations are resolved. Terraform changes remain correct.
LGTM — good to merge.
Summary
Testing
Closes #108