Skip to content

Add chat-app and tracing-app deployments#114

Merged
vitramir merged 2 commits intomainfrom
noa/issue-113
Mar 17, 2026
Merged

Add chat-app and tracing-app deployments#114
vitramir merged 2 commits intomainfrom
noa/issue-113

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add chat-app/tracing-app chart variables, locals, and Helm values
  • add Argo CD applications and Istio VirtualServices for new apps
  • include chat-app and tracing-app in platform outputs

Testing

  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform fmt -check
  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform validate

Refs #113

@casey-brooks casey-brooks requested a review from a team as a code owner March 17, 2026 11:25
@casey-brooks
Copy link
Contributor Author

Summary

  • add chat-app/tracing-app variables, locals, and Helm values
  • add Argo CD applications and Istio VirtualServices for the new apps
  • include chat-app and tracing-app in platform outputs

Testing

  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform fmt -check
  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform validate

Tests: passed 1, failed 0, skipped 0
Lint: terraform fmt -check (no issues)

noa-lucent
noa-lucent previously approved these changes Mar 17, 2026
Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation. All six sections from the issue spec are covered:

  • Variables: 4 new variables for chart versions and image tag overrides — consistent with existing naming and structure.
  • Locals: Resolved image tags follow the trimspace fallback pattern used by files, notifications, etc. Chart names correct.
  • Helm values: Follow the platform_ui_values structure (extraVolumes/extraVolumeMounts for nginx read-only root filesystem). Differences from platform_ui (no ingress, ClusterIP vs NodePort, no probes/env) are intentional per spec.
  • ArgoCD applications: Sync wave 25, same depends_on, sync policy, and destination as platform_ui.
  • VirtualServices: Subdomain-based routing (chat. / tracing.) with consistent computed_fields and depends_on.
  • Outputs: Both apps added to platform_app_names and platform_app_ids.

No correctness, style, or architectural issues found.

@casey-brooks
Copy link
Contributor Author

Summary

  • bump chat-app and tracing-app chart version defaults to v0.1.1

Testing

  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform fmt -check
  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform validate

Tests: passed 1, failed 0, skipped 0
Lint: terraform fmt -check (no issues)

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed after the version bump commit. The only change since my previous (dismissed) approval is the two default bumps in variables.tf:

  • chat_app_chart_version: "0.1.0""0.1.1"
  • tracing_app_chart_version: "0.1.0""0.1.1"

All other code (main.tf, outputs.tf) is identical to what I previously approved. No issues.

@vitramir vitramir merged commit b7f2ccf into main Mar 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants