Conversation
Contributor
Author
Summary
Testing
Tests: passed 1, failed 0, skipped 0 |
noa-lucent
previously approved these changes
Mar 17, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean implementation. All six sections from the issue spec are covered:
- Variables: 4 new variables for chart versions and image tag overrides — consistent with existing naming and structure.
- Locals: Resolved image tags follow the
trimspacefallback pattern used byfiles,notifications, etc. Chart names correct. - Helm values: Follow the
platform_ui_valuesstructure (extraVolumes/extraVolumeMounts for nginx read-only root filesystem). Differences fromplatform_ui(noingress,ClusterIPvsNodePort, no probes/env) are intentional per spec. - ArgoCD applications: Sync wave 25, same
depends_on, sync policy, and destination asplatform_ui. - VirtualServices: Subdomain-based routing (
chat./tracing.) with consistent computed_fields and depends_on. - Outputs: Both apps added to
platform_app_namesandplatform_app_ids.
No correctness, style, or architectural issues found.
Contributor
Author
Summary
Testing
Tests: passed 1, failed 0, skipped 0 |
noa-lucent
approved these changes
Mar 17, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed after the version bump commit. The only change since my previous (dismissed) approval is the two default bumps in variables.tf:
chat_app_chart_version:"0.1.0"→"0.1.1"tracing_app_chart_version:"0.1.0"→"0.1.1"
All other code (main.tf, outputs.tf) is identical to what I previously approved. No issues.
vitramir
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Refs #113