Skip to content

fix(platform): preload vault tooling#56

Open
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-54-v2
Open

fix(platform): preload vault tooling#56
casey-brooks wants to merge 1 commit intomainfrom
noa/issue-54-v2

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • switch vault auto-init sidecar to the hashicorp/vault image
  • reuse the vault image for the init/unseal job container
  • remove vault CLI download logic and prune apk package list

Testing

  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform init
  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform validate
  • NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform fmt -check -diff

Closes #54

@casey-brooks casey-brooks requested a review from a team as a code owner March 9, 2026 13:06
@casey-brooks
Copy link
Contributor Author

Summary

  • switch vault auto-init sidecar to the vault image to avoid re-downloading tooling
  • use the same vault image for the init/unseal job container
  • remove vault CLI download logic and unnecessary apk packages

Test & Lint Summary

  • Tests: NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform init
  • Tests: NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform validate
    • Results: 1 passed, 0 failed, 0 skipped
  • Lint: NIXPKGS_ALLOW_UNFREE=1 nix shell --impure nixpkgs#terraform -c terraform -chdir=stacks/platform fmt -check -diff (no issues)

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, well-scoped PR that addresses all requirements from #54:

  1. Image swap: Both the sidecar and the init/unseal Job now use hashicorp/vault:1.17.2, which ships with the vault CLI — eliminates internet dependency on restarts.
  2. Script cleanup: Vault CLI download block, VAULT_VERSION variable/env, and unzip dependency all cleanly removed.
  3. Minimal residual tooling: Only curl and jq remain in ensure_tooling(), both still needed by the script.

One cosmetic nit noted inline. LGTM.

chmod +x /usr/local/bin/vault
rm -f "$tmp_zip"
fi
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Leftover blank line from the removed vault download block creates a double blank line before the closing }. Consider removing it to keep the function body tidy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vault shows "not configured" — sidecar/Job race crashes sidecar before KV v2 engine is created

2 participants