Skip to content

refactor(platform): remove docker-runner#1399

Merged
vitramir merged 3 commits intomainfrom
noa/issue-1398
Mar 14, 2026
Merged

refactor(platform): remove docker-runner#1399
vitramir merged 3 commits intomainfrom
noa/issue-1398

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • remove docker-runner package/chart and update CI/buf configs
  • move docker-runner container types/utilities into platform-server infra/container
  • update platform-server tests/e2e docs for external runner

Testing

  • pnpm --filter @agyn/platform-server test
  • pnpm --filter @agyn/platform-server exec vitest run --reporter=json --outputFile /tmp/vitest-report.json
  • pnpm --filter @agyn/platform-server lint

#1398

@casey-brooks casey-brooks requested a review from a team as a code owner March 14, 2026 12:25
@casey-brooks
Copy link
Contributor Author

Summary

  • remove docker-runner package/chart and update CI/buf configs
  • move docker-runner container types/utilities into platform-server infra/container
  • adjust platform-server tests and docs for external runner

Testing

  • pnpm --filter @agyn/platform-server test
  • pnpm --filter @agyn/platform-server exec vitest run --reporter=json --outputFile /tmp/vitest-report.json
    • Tests: 750 passed, 0 failed, 28 skipped
  • pnpm --filter @agyn/platform-server lint
    • Lint: no errors

Copy link
Contributor

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and well-scoped removal of docker-runner from the monorepo. All inlined code is faithfully copied from the original sources with only import paths and unused exports pruned. CI, config, and documentation updates are correct and complete. No remaining @agyn/docker-runner references.

One major issue to address before merge:

createDockerClientStub duplication (7+ copies): The ~25-line DockerClientPort/DockerClient stub factory is copy-pasted across many test files. Extract into a shared test helper to prevent maintenance drift.

One minor cleanup is also noted (dead socketPath parameter and redundant startDockerRunnerProcess wrapper).

* feat(entities): add secret provider kinds

* refactor(secrets): move to gateway CRUD

* refactor(ui): extract secrets helpers

* fix(secrets): use token pagination

* feat(ui): add secret upsert pages

* fix(ui): stabilize dropdown selections

* fix(ui): align secret form sizes
@casey-brooks
Copy link
Contributor Author

Summary

  • extract shared docker client stubs into __tests__/helpers/dockerClient.stub.ts
  • update test imports/usages and align docker e2e runner helper signature

Testing

  • pnpm --filter @agyn/platform-server test
  • pnpm --filter @agyn/platform-server exec vitest run --reporter=json --outputFile /tmp/vitest-report.json
    • Tests: 750 passed, 0 failed, 28 skipped
  • pnpm --filter @agyn/platform-server lint
    • Lint: no errors

Copy link
Contributor

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both prior review comments are fully addressed:

  1. Stub duplication resolved: createDockerClientPortStub and createDockerClientStub extracted into __tests__/helpers/dockerClient.stub.ts. All 7+ test files now import from the shared helper — zero inline copies remain. The helper is well-structured: DockerClient variant composes on the DockerClientPort base, all methods are vi.fn() for mockability.

  2. E2e helper cleanup done: socketPath parameter removed from startDockerRunner, void socketPath gone, startDockerRunnerProcess collapsed. All 4 callers updated to the parameterless signature with dead socketPath computation removed.

LGTM — clean extraction of docker-runner from the monorepo.

@vitramir vitramir added this pull request to the merge queue Mar 14, 2026
Merged via the queue into main with commit 04241ca Mar 14, 2026
7 checks passed
casey-brooks added a commit that referenced this pull request Mar 15, 2026
* refactor(platform): drop docker-runner

* feat: add secret provider entities (#1394)

* feat(entities): add secret provider kinds

* refactor(secrets): move to gateway CRUD

* refactor(ui): extract secrets helpers

* fix(secrets): use token pagination

* feat(ui): add secret upsert pages

* fix(ui): stabilize dropdown selections

* fix(ui): align secret form sizes

* test: centralize docker client stubs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants