Conversation
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
Clean and well-scoped removal of docker-runner from the monorepo. All inlined code is faithfully copied from the original sources with only import paths and unused exports pruned. CI, config, and documentation updates are correct and complete. No remaining @agyn/docker-runner references.
One major issue to address before merge:
createDockerClientStub duplication (7+ copies): The ~25-line DockerClientPort/DockerClient stub factory is copy-pasted across many test files. Extract into a shared test helper to prevent maintenance drift.
One minor cleanup is also noted (dead socketPath parameter and redundant startDockerRunnerProcess wrapper).
packages/platform-server/__tests__/tools/shell.timeout.behavior.test.ts
Outdated
Show resolved
Hide resolved
* feat(entities): add secret provider kinds * refactor(secrets): move to gateway CRUD * refactor(ui): extract secrets helpers * fix(secrets): use token pagination * feat(ui): add secret upsert pages * fix(ui): stabilize dropdown selections * fix(ui): align secret form sizes
Summary
Testing
|
noa-lucent
left a comment
There was a problem hiding this comment.
Both prior review comments are fully addressed:
-
Stub duplication resolved:
createDockerClientPortStubandcreateDockerClientStubextracted into__tests__/helpers/dockerClient.stub.ts. All 7+ test files now import from the shared helper — zero inline copies remain. The helper is well-structured:DockerClientvariant composes on theDockerClientPortbase, all methods arevi.fn()for mockability. -
E2e helper cleanup done:
socketPathparameter removed fromstartDockerRunner,void socketPathgone,startDockerRunnerProcesscollapsed. All 4 callers updated to the parameterless signature with deadsocketPathcomputation removed.
LGTM — clean extraction of docker-runner from the monorepo.
* refactor(platform): drop docker-runner * feat: add secret provider entities (#1394) * feat(entities): add secret provider kinds * refactor(secrets): move to gateway CRUD * refactor(ui): extract secrets helpers * fix(secrets): use token pagination * feat(ui): add secret upsert pages * fix(ui): stabilize dropdown selections * fix(ui): align secret form sizes * test: centralize docker client stubs
Summary
Testing
#1398