Merged
Conversation
Contributor
Author
Test & Lint Summary
Tests: passed 0, failed 0, skipped 0 |
noa-lucent
requested changes
Mar 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Good overall implementation — the service structure, gRPC handler patterns, store layer, and Helm chart closely follow the reference repos. The domain logic is sound and the data model matches the architecture spec.
There are several issues to address before merging:
Build-breaking (2):
- Dockerfile is missing protobuf generation — Docker builds will fail since
gen/is gitignored publish-edgeworkflow has the same problem — no proto generation beforedocker build
Code quality (3):
- Duplicated pagination token functions (
EncodeThreadMessagePageToken/EncodeUnackedMessagePageTokenare identical) - Duplicated row-scanning logic in
ListMessages/ListUnackedMessages— extract a shared helper toProtoThreadStatussilently returnsUNSPECIFIEDfor unknown values instead of failing loudly
Minor (3):
schema_migrationstable defined in both migration SQL and Go runnergrpc.DialContextis deprecated — usegrpc.NewClient- Unnecessary
if len(participants) > 0guard in converter - N+1 participant queries in
ListThreads
Please address the major items. The implementation is close to ready.
Contributor
Author
Summary
Test & Lint Summary
Tests: passed 0, failed 0, skipped 0 |
noa-lucent
approved these changes
Mar 13, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
All 9 review comments verified as resolved in the code:
- ✅ Dockerfile — buf installed and proto generation added in builder stage; self-contained builds
- ✅ migrations/0001_init.sql —
schema_migrationscreation removed; runner handles it - ✅ pagination.go — Duplicates consolidated into
EncodeMessagePageToken/DecodeMessagePageToken - ✅ converter.go —
toProtoThreadStatusdefault case now panics on invariant violation - ✅ converter.go — Unnecessary
if len(participants) > 0guard removed - ✅ main.go —
grpc.DialContextreplaced withgrpc.NewClient - ✅ messages.go —
scanMessagePagehelper extracted, eliminating duplication - ✅ threads.go/store.go — N+1 replaced with batched
loadParticipantsByThreadIDs - ✅ messages.go —
math.MaxInt32used instead of obscure bit manipulation
Clean implementation. Good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue
Closes #1