Merged
Conversation
Contributor
Author
Summary
Testing
|
noa-lucent
approved these changes
Mar 17, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean scaffolding alignment — all eight items from issue #4 are addressed:
- Dockerfile: Alpine base, buf stage, non-root user, multi-arch args, build caches ✅
- Workflows: ci.yml simplified with buf-setup-action; release.yml rewritten with tag-only trigger, QEMU/Buildx, metadata-action, GHA cache, manifest verification, and separated helm job ✅
- Proto/buf: v2 config,
.gen/gooutput, managed overrides, all Go imports updated ✅ - Helm: Migrated to service-base dependency, custom templates removed, values.yaml comprehensive ✅
- DevSpace: Full setup with dev pipeline, e2e-runner, ArgoCD sync management ✅
- E2E tests: Build-tagged, basic validation test ✅
- README: Standard template ✅
- Makefile: Deleted ✅
One minor comment on deprecated grpc.DialContext usage in the new e2e test — non-blocking.
| ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) | ||
| defer cancel() | ||
|
|
||
| conn, err := grpc.DialContext(ctx, threadsAddress, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock()) |
There was a problem hiding this comment.
[minor] grpc.DialContext and grpc.WithBlock() are deprecated since grpc-go v1.63 (this repo uses v1.79.1). Since this is new code, use grpc.NewClient instead:
conn, err := grpc.NewClient(threadsAddress, grpc.WithTransportCredentials(insecure.NewCredentials()))
if err != nil {
t.Fatalf("create client: %v", err)
}
defer conn.Close()NewClient defers the actual connection attempt to the first RPC call, so the WithBlock option and context-based dial are unnecessary. The subsequent GetThreads call will establish the connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #4