Skip to content

feat: add notification bell component#5

Open
dylantarre wants to merge 1 commit intomainfrom
test/buoy-0.3.16
Open

feat: add notification bell component#5
dylantarre wants to merge 1 commit intomainfrom
test/buoy-0.3.16

Conversation

@dylantarre
Copy link
Copy Markdown
Contributor

Adds a notification bell with badge count for the React app.

@ahoybuoy
Copy link
Copy Markdown
Contributor

ahoybuoy Bot commented Feb 15, 2026

🛟 Buoy Design Review

3 issues in 1 file

File Line Issue
NotificationBell.tsx 21 hardcoded-spacing: 18px
NotificationBell.tsx 22 hardcoded-spacing: 18px
NotificationBell.tsx 7 inline-style: position: 'relative', display: 'inline-block', cursor: 'pointer'

You're using hardcoded spacing values like 18px and 4px in multiple places, which are great candidates for tokens. Since you're using shadcn, consider naming these --spacing-sm and --spacing-xs to keep things consistent. The inline styles for positioning and layout could also benefit from a shared utility class or token.

Tip: Start by defining these spacing values as tokens in your design system to avoid repetition and make future updates easier.

3 issues · reply @ahoybuoy for help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant