Skip to content

refactor: use common base class for all exceptions#275

Open
domire8 wants to merge 12 commits into
mainfrom
feat/exceptions
Open

refactor: use common base class for all exceptions#275
domire8 wants to merge 12 commits into
mainfrom
feat/exceptions

Conversation

@domire8

@domire8 domire8 commented Apr 28, 2026

Copy link
Copy Markdown
Member

Description

Big scary refactor PR here. All exceptions of state_representation, dynamical_systems, controllers and robot_model now inherit from one exception class state_representation::exceptions::Exception. Also, instead of using one header per exception class, they can now all be found under a file exceptions.hpp. It is similar to what we did in modulo already.

Review guidelines

Estimated Time of Review: 10 minutes

Checklist before merging:

  • Confirm that the relevant changelog(s) are up-to-date in case of any user-facing changes

@domire8 domire8 requested a review from eeberhard as a code owner April 28, 2026 15:23
@domire8 domire8 requested review from SprGrf and yrh012 April 28, 2026 15:23
@domire8 domire8 linked an issue Apr 28, 2026 that may be closed by this pull request
@domire8 domire8 force-pushed the feat/exceptions branch from 14ada76 to 19cf13e Compare May 1, 2026 05:46

@yrh012 yrh012 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Common base class for exceptions

3 participants