-
Notifications
You must be signed in to change notification settings - Fork 0
task: add domain entities for application runs and items #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+754
−12
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
123 changes: 123 additions & 0 deletions
123
packages/sdk/src/entities/application-run/process-application-run.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { processApplicationRun } from './process-application-run.js'; | ||
| import type { RunReadResponse } from '../../generated/index.js'; | ||
|
|
||
| function buildRun( | ||
| overrides: Partial<Pick<RunReadResponse, 'state' | 'termination_reason'>> & { | ||
| statistics?: Partial<RunReadResponse['statistics']>; | ||
| } = {} | ||
| ): RunReadResponse { | ||
| return { | ||
| run_id: 'run-1', | ||
| application_id: 'app-1', | ||
| version_number: '1.0.0', | ||
| state: overrides.state ?? 'PENDING', | ||
| output: 'NONE', | ||
| termination_reason: overrides.termination_reason ?? null, | ||
| error_code: null, | ||
| error_message: null, | ||
| submitted_at: '2026-01-01T00:00:00Z', | ||
| submitted_by: 'user-1', | ||
| statistics: { | ||
| item_count: 0, | ||
| item_pending_count: 0, | ||
| item_processing_count: 0, | ||
| item_user_error_count: 0, | ||
| item_system_error_count: 0, | ||
| item_skipped_count: 0, | ||
| item_succeeded_count: 0, | ||
| ...overrides.statistics, | ||
| }, | ||
| } as RunReadResponse; | ||
| } | ||
|
|
||
| describe('processApplicationRun', () => { | ||
| it('should preserve all original RunReadResponse fields', () => { | ||
| const raw = buildRun({ state: 'PENDING' }); | ||
| const result = processApplicationRun(raw); | ||
|
|
||
| expect(result.run_id).toBe(raw.run_id); | ||
| expect(result.application_id).toBe(raw.application_id); | ||
| expect(result.version_number).toBe(raw.version_number); | ||
| expect(result.state).toBe(raw.state); | ||
| expect(result.statistics).toEqual(raw.statistics); | ||
| }); | ||
|
|
||
| it('should add progress property for a PENDING run with no items', () => { | ||
| const result = processApplicationRun(buildRun({ state: 'PENDING' })); | ||
| expect(result.progress).toBe(0); | ||
| }); | ||
|
|
||
| it('should add status property for a PENDING run', () => { | ||
| const result = processApplicationRun(buildRun({ state: 'PENDING' })); | ||
| expect(result.status).toBe('PENDING'); | ||
| }); | ||
|
|
||
| it('should add can_download property for a PENDING run', () => { | ||
| const result = processApplicationRun(buildRun({ state: 'PENDING' })); | ||
| expect(result.can_download).toBe(false); | ||
| }); | ||
|
|
||
| it('should compute correct values for a completed run', () => { | ||
| const raw = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { item_count: 10, item_succeeded_count: 10 }, | ||
| }); | ||
| const result = processApplicationRun(raw); | ||
|
|
||
| expect(result.progress).toBe(100); | ||
| expect(result.status).toBe('COMPLETED'); | ||
| expect(result.can_download).toBe(true); | ||
| }); | ||
|
|
||
| it('should compute correct values for a run completed with errors', () => { | ||
| const raw = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { | ||
| item_count: 10, | ||
| item_succeeded_count: 7, | ||
| item_user_error_count: 3, | ||
| }, | ||
| }); | ||
| const result = processApplicationRun(raw); | ||
|
|
||
| expect(result.progress).toBe(100); | ||
| expect(result.status).toBe('COMPLETED_WITH_ERRORS'); | ||
| expect(result.can_download).toBe(true); | ||
| }); | ||
|
|
||
| it('should compute correct values for a canceled run', () => { | ||
| const raw = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'CANCELED_BY_USER', | ||
| statistics: { | ||
| item_count: 10, | ||
| item_succeeded_count: 3, | ||
| }, | ||
| }); | ||
| const result = processApplicationRun(raw); | ||
|
|
||
| expect(result.progress).toBe(30); | ||
| expect(result.status).toBe('CANCELED'); | ||
| expect(result.can_download).toBe(false); | ||
| }); | ||
|
|
||
| it('should compute correct values for a processing run', () => { | ||
| const raw = buildRun({ | ||
| state: 'PROCESSING', | ||
| statistics: { | ||
| item_count: 20, | ||
| item_succeeded_count: 8, | ||
| item_processing_count: 4, | ||
| item_pending_count: 8, | ||
| }, | ||
| }); | ||
| const result = processApplicationRun(raw); | ||
|
|
||
| expect(result.progress).toBe(40); | ||
| expect(result.status).toBe('PROCESSING'); | ||
| expect(result.can_download).toBe(false); | ||
| }); | ||
| }); | ||
22 changes: 22 additions & 0 deletions
22
packages/sdk/src/entities/application-run/process-application-run.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { ApplicationRun } from './types.js'; | ||
| import { RunReadResponse } from '../../generated/index.js'; | ||
| import { getRunProgress, getRunStatus, canDownloadRunItems } from './utils.js'; | ||
|
|
||
| /** | ||
| * Transform a raw {@link RunReadResponse} from the API into an enriched | ||
| * {@link ApplicationRun} by computing derived properties (progress, status, can_download). | ||
| * | ||
| * This is the single entry-point used by `PlatformSDKHttp` methods to map API | ||
| * responses before returning them to consumers. | ||
| * | ||
| * @param run - Raw run response from the API | ||
| * @returns Enriched run entity with computed properties spread onto the original response | ||
| */ | ||
| export const processApplicationRun = (run: RunReadResponse): ApplicationRun => { | ||
| return { | ||
| ...run, | ||
| progress: getRunProgress(run), | ||
| status: getRunStatus(run), | ||
| can_download: canDownloadRunItems(run), | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| import { RunReadResponse } from '../../generated/index.js'; | ||
|
|
||
| /** | ||
| * Enriched application run entity that extends the raw API response | ||
| * with computed properties derived from run state and statistics. | ||
| * | ||
| * Returned by `PlatformSDKHttp.listApplicationRuns()` and `PlatformSDKHttp.getRun()` | ||
| * instead of the raw `RunReadResponse`. | ||
| */ | ||
| export interface ApplicationRun extends RunReadResponse { | ||
| /** Percentage of items processed (0–100), computed from run statistics. */ | ||
| progress: number; | ||
| /** Human-readable status derived from `state` and `termination_reason`. */ | ||
| status: RunStatus; | ||
| /** Whether the run's result items are available for download. */ | ||
| can_download: boolean; | ||
| } | ||
|
|
||
| /** Derived run status that simplifies the raw `state` + `termination_reason` combination. */ | ||
| export type RunStatus = | ||
| | 'PENDING' | ||
| | 'PROCESSING' | ||
| | 'COMPLETED' | ||
| | 'COMPLETED_WITH_ERRORS' | ||
| | 'CANCELED' | ||
| | 'FAILED'; |
205 changes: 205 additions & 0 deletions
205
packages/sdk/src/entities/application-run/utils.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,205 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { getRunProgress, getRunStatus, canDownloadRunItems } from './utils.js'; | ||
| import type { RunReadResponse } from '../../generated/index.js'; | ||
|
|
||
| /** | ||
| * Helper to build a minimal RunReadResponse with sensible defaults. | ||
| * Only the fields used by the utility functions need to be realistic. | ||
| */ | ||
| function buildRun( | ||
| overrides: Partial<Pick<RunReadResponse, 'state' | 'termination_reason'>> & { | ||
| statistics?: Partial<RunReadResponse['statistics']>; | ||
| } = {} | ||
| ): RunReadResponse { | ||
| return { | ||
| run_id: 'run-1', | ||
| application_id: 'app-1', | ||
| version_number: '1.0.0', | ||
| state: overrides.state ?? 'PENDING', | ||
| output: 'NONE', | ||
| termination_reason: overrides.termination_reason ?? null, | ||
| error_code: null, | ||
| error_message: null, | ||
| submitted_at: '2026-01-01T00:00:00Z', | ||
| submitted_by: 'user-1', | ||
| statistics: { | ||
| item_count: 0, | ||
| item_pending_count: 0, | ||
| item_processing_count: 0, | ||
| item_user_error_count: 0, | ||
| item_system_error_count: 0, | ||
| item_skipped_count: 0, | ||
| item_succeeded_count: 0, | ||
| ...overrides.statistics, | ||
| }, | ||
| } as RunReadResponse; | ||
| } | ||
|
|
||
| describe('getRunProgress', () => { | ||
| it('should return 0 when item_count is 0', () => { | ||
| const run = buildRun({ statistics: { item_count: 0 } }); | ||
| expect(getRunProgress(run)).toBe(0); | ||
| }); | ||
|
|
||
| it('should return 100 when all items succeeded', () => { | ||
| const run = buildRun({ | ||
| statistics: { item_count: 10, item_succeeded_count: 10 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(100); | ||
| }); | ||
|
|
||
| it('should return 50 when half the items are processed', () => { | ||
| const run = buildRun({ | ||
| statistics: { item_count: 10, item_succeeded_count: 5 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(50); | ||
| }); | ||
|
|
||
| it('should include user errors in the processed count', () => { | ||
| const run = buildRun({ | ||
| statistics: { item_count: 10, item_user_error_count: 3, item_succeeded_count: 7 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(100); | ||
| }); | ||
|
|
||
| it('should include system errors in the processed count', () => { | ||
| const run = buildRun({ | ||
| statistics: { item_count: 4, item_system_error_count: 2, item_succeeded_count: 1 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(75); | ||
| }); | ||
|
|
||
| it('should include skipped items in the processed count', () => { | ||
| const run = buildRun({ | ||
| statistics: { item_count: 5, item_skipped_count: 2, item_succeeded_count: 3 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(100); | ||
| }); | ||
|
|
||
| it('should round to the nearest integer', () => { | ||
| // 1/3 = 33.33...% → 33 | ||
| const run = buildRun({ | ||
| statistics: { item_count: 3, item_succeeded_count: 1 }, | ||
| }); | ||
| expect(getRunProgress(run)).toBe(33); | ||
| }); | ||
|
|
||
| it('should combine all terminal item types', () => { | ||
| const run = buildRun({ | ||
| statistics: { | ||
| item_count: 20, | ||
| item_succeeded_count: 5, | ||
| item_user_error_count: 3, | ||
| item_system_error_count: 2, | ||
| item_skipped_count: 4, | ||
| }, | ||
| }); | ||
| // (5 + 3 + 2 + 4) / 20 = 14/20 = 70% | ||
| expect(getRunProgress(run)).toBe(70); | ||
| }); | ||
| }); | ||
|
|
||
| describe('getRunStatus', () => { | ||
| it('should return PENDING when state is PENDING', () => { | ||
| const run = buildRun({ state: 'PENDING' }); | ||
| expect(getRunStatus(run)).toBe('PENDING'); | ||
| }); | ||
|
|
||
| it('should return PROCESSING when state is PROCESSING', () => { | ||
| const run = buildRun({ state: 'PROCESSING' }); | ||
| expect(getRunStatus(run)).toBe('PROCESSING'); | ||
| }); | ||
|
|
||
| it('should return CANCELED when terminated by user', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'CANCELED_BY_USER', | ||
| }); | ||
| expect(getRunStatus(run)).toBe('CANCELED'); | ||
| }); | ||
|
|
||
| it('should return FAILED when terminated by system', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'CANCELED_BY_SYSTEM', | ||
| }); | ||
| expect(getRunStatus(run)).toBe('FAILED'); | ||
| }); | ||
|
|
||
| it('should return COMPLETED when all items succeeded', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { item_count: 10, item_succeeded_count: 10 }, | ||
| }); | ||
| expect(getRunStatus(run)).toBe('COMPLETED'); | ||
| }); | ||
|
|
||
| it('should return COMPLETED_WITH_ERRORS when not all items succeeded', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { item_count: 10, item_succeeded_count: 7 }, | ||
| }); | ||
| expect(getRunStatus(run)).toBe('COMPLETED_WITH_ERRORS'); | ||
| }); | ||
|
|
||
| it('should return COMPLETED_WITH_ERRORS when some items had errors', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { | ||
| item_count: 10, | ||
| item_succeeded_count: 8, | ||
| item_user_error_count: 2, | ||
| }, | ||
| }); | ||
| expect(getRunStatus(run)).toBe('COMPLETED_WITH_ERRORS'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('canDownloadRunItems', () => { | ||
| it('should return false for PENDING runs', () => { | ||
| const run = buildRun({ state: 'PENDING' }); | ||
| expect(canDownloadRunItems(run)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return false for PROCESSING runs', () => { | ||
| const run = buildRun({ state: 'PROCESSING' }); | ||
| expect(canDownloadRunItems(run)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return false for CANCELED runs', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'CANCELED_BY_USER', | ||
| }); | ||
| expect(canDownloadRunItems(run)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return false for FAILED runs', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'CANCELED_BY_SYSTEM', | ||
| }); | ||
| expect(canDownloadRunItems(run)).toBe(false); | ||
| }); | ||
|
|
||
| it('should return true for COMPLETED runs', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { item_count: 5, item_succeeded_count: 5 }, | ||
| }); | ||
| expect(canDownloadRunItems(run)).toBe(true); | ||
| }); | ||
|
|
||
| it('should return true for COMPLETED_WITH_ERRORS runs', () => { | ||
| const run = buildRun({ | ||
| state: 'TERMINATED', | ||
| termination_reason: 'ALL_ITEMS_PROCESSED', | ||
| statistics: { item_count: 5, item_succeeded_count: 3 }, | ||
| }); | ||
| expect(canDownloadRunItems(run)).toBe(true); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.