Conversation
There was a problem hiding this comment.
Thanks! @danielhollas Last change #318 as you said is an omission.
I think the default BASE in stack/base/Dockerfile is set in docker-bake.hcl for build the image. Remove the ARG BASE=jupyter/minimal-notebook:python-3.9.13 should be fine and good to have only one place to set the version.
|
If seems the variable can not pass directly to |
|
@unkcpz thanks! I just confirmed that the images published before this PR were still on Python 9.4, so the PR in #318 didn't work. I'll open a new PR where I will do the same fix for |
This was an omission in #318. The Python version specified in
build.jsonis used to automatically generate the image tags on Dockerhub. So currently, for example the imageaiidalab/full-stack:python-9.4actually corresponds to python-9.13https://hub.docker.com/r/aiidalab/full-stack/tags
In short, when updating the Python version, we need to update both the
stack/base/Dockerfileandbuild.json