Merged
Conversation
danielhollas
commented
Jul 7, 2024
| # Upgrade pip and mamba to latest | ||
| # Install aiida-core and other shared requirements. | ||
| RUN mamba install --yes \ | ||
| RUN mamba update -y pip && \ |
Contributor
Author
There was a problem hiding this comment.
Combining mamba update and mamba install in a single RUN should speed up the build slightly since we need to download the conda-forge package index only once.
mikibonacci
approved these changes
Jul 8, 2024
Member
mikibonacci
left a comment
mikibonacci
left a comment
There was a problem hiding this comment.
Hi @danielhollas , LGTM! Thanks!
danielhollas
added a commit
that referenced
this pull request
Jul 21, 2024
This reverts commit 36a565e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minor update, mostly important for later when we switch to Python 3.11 in #455, but let's deploy it now.
Changelog available here:
https://github.com/aiidalab/aiidalab/releases/tag/v24.07.0