♻️ EpwPrepWorkChain: get target_base using tool function#45
Merged
Conversation
…ault - Rename `get_target_basepath` to `get_default_target_basepath` in tools. - Refactor option/stash handling in `EpwPrepWorkChain` to avoid the legacy `metadata` namespace and query `get_default_target_basepath` inline. - Add test coverage for `get_default_target_basepath`.
…rep get_builder_from_protocol
…h and use get_default_target_basepath
LIU-Binbin
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor option/stash handling in
EpwPrepWorkChainto avoid the legacymetadatanamespace and useget_default_target_basepathto get the default setting oftarget_basepath.Set the default
stash_modeas copy to avoid crash of process.