Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements Google Cloud Storage support as described in this issue: #3391.
I've added 'google-cloud-storage' as an extra, installable via aim[gcs]. In the future, boto3 should probably also be handled like this.
How to test these changes locally
Optionally, host a local gcs emulator:
Then, create a new project, add
path/to/aim[gcs]as a dependency, and test:Note: As of right now, there are no tests implemented for (any) artifact storage. These could either be added to this PR or (because adding them would imply testing things unrelated to this pr) be implemented in another PR.