fix(ui): guard explorer selectors on slow networks#3396
Open
rajatbeladiya wants to merge 1 commit intoaimhubio:mainfrom
Open
fix(ui): guard explorer selectors on slow networks#3396rajatbeladiya wants to merge 1 commit intoaimhubio:mainfrom
rajatbeladiya wants to merge 1 commit intoaimhubio:mainfrom
Conversation
|
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Disable selector buttons until options are loaded to prevent error state on slow networks.\n\nCloses aimhubio#1574.
fe4b819 to
046200c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue where clicking explorer selector buttons (e.g. +Metrics/+Params/+Images) immediately after page load on a slow network can lead to an error state.
Changes:
selectFormData.optionsis available.Tested:
aim up) with artificial fetch latency and verified selectors remain stable.npx eslinton modified files.Closes #1574.