Skip to content

fix: repaire the logic of eval task stats update #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chanzhi82020 wants to merge 1 commit into
base: eval-dev
Choose a base branch
from
Draft

fix: repaire the logic of eval task stats update #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions packages/global/core/evaluation/api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ import type {
EvaluationItemSchemaType,
EvaluationDisplayType,
EvaluationItemDisplayType,
EvaluationDataItemType
EvaluationDataItemType,
EvaluationStatistics
} from './type';

// ===== Common Types =====
Expand Down Expand Up @@ -51,7 +52,6 @@ export type EvaluationStatsResponse = {
evaluating: number;
queuing: number;
error: number;
avgScore?: number;
};

// Export Evaluation Items
Expand Down Expand Up @@ -112,12 +112,7 @@ export type DataItemGroupedItem = {
dataItemId: string;
dataItem: EvaluationDataItemType;
items: EvaluationItemDisplayType[];
summary: {
totalItems: number;
completedItems: number;
errorItems: number;
avgScore?: number;
};
statistics?: EvaluationStatistics;
};
export type DataItemListResponse = PaginationResponse<DataItemGroupedItem>;

Expand Down
2 changes: 1 addition & 1 deletion packages/global/core/evaluation/type.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ export type EvaluationDisplayType = Pick<
| 'statistics'
> & {
_id: string;
avgScore?: number;
datasetName?: string;
target: EvalTarget; // Complete target object with extended config
metricNames: string[];
Expand All @@ -161,6 +160,7 @@ export interface CreateEvaluationParams {
datasetId: string;
target: EvalTarget; // Only supports workflow type target configuration
evaluators: EvaluatorSchema[]; // Replace metricIds with evaluators
autoStart?: boolean; // Whether to automatically start the evaluation task after creation (default: true)
}

// Queue job data types
Expand Down
Loading
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.