Conversation
but still make the stats socket readable if a name exists
they don't add any additional information
this is instead of looking for it in the node name, which is properly metadata. this allows us to always generate ephemeral sequence ids for nerve node names and still have readable information in haproxy
this is an alternate approach to #29 which is not tied to particular service watchers. as long as the watcher ads a numeric ID field to each backend hash, a leader can be elected. if a leader cannot be elected, we fail hard by returning no backends
|
@igor47 this works great in a happy scenario, but in edge cases like Synapse unable to connect to ZK (which delegates the health check to haproxy by default), and then the master node fails, this will cause downtime. |
|
This PR addresses the backup option #83 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is an alternate approach to #29 which assumes that nerve has already been modified to create sequential ids. such a change is still pending; without it, the haproxy status page will become less readable to administrators.
@Dareen how does this compare with your vision?