Skip to content

fix: dead footer/modal links and missing OG image asset#170

Merged
bumu merged 2 commits into
mainfrom
claude/code-review-fixes-sz852l
Jul 17, 2026
Merged

fix: dead footer/modal links and missing OG image asset#170
bumu merged 2 commits into
mainfrom
claude/code-review-fixes-sz852l

Conversation

@bumu

@bumu bumu commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add public/social.webp (converted from src/images/social.png via sharp) — astro.config.mjs's Starlight og:image/twitter:image meta tags pointed at this path but the file never existed, so link previews for any docs page were broken.
  • Point the signup modal's "Terms and Conditions" link at the terms-of-service page that already exists instead of #.
  • Remove the footer's dead "Careers"/"招聘" link (no careers page exists on the site) in both the en and zh-cn nav data.
  • Fix the footer's "Consultation Services"/"技术咨询服务" link, which pointed at /services (404) instead of the actual /solutions route.
  • Set package.json's empty "name" field to "airdb-website".
  • Add a third pricing tier ("Growth Plan") — PricingSection.astro was hardcoded for exactly two cards even though its CSS was already built for three columns. Point "Get a Custom Quote" at /contact instead of #.
  • Add a sixth service to /solutions ("Technical Advisory & Managed IT Services") tying back to the CTO/CIO/CISO/DPO-as-a-service line already promised on the pricing page. Fix alt text across all solutions.astro images (they still described the original template's construction-site photos even though the images themselves were already swapped to AI/data-center imagery). Fix a leftover "硬件和软件行业" phrase on the zh-cn page. Point remaining dead # CTAs at /contact.
  • Fix a regression this surfaced: FooterSection.astro picked the "We're hiring!" badge by hardcoded array index, which used to line up with "Careers" — after that link was removed it had silently shifted onto "Blog". Removed the index-based badge.

This is a follow-up to #169 (already merged) — same branch, continued after that PR landed.

Test plan

  • astro check — 0 errors, 0 warnings
  • Verified /services was not a real route and /solutions is
  • Verified /about/terms-of-service/ exists
  • Generated and inspected public/social.webp (1024x1024 webp, 81KB)
  • Ran astro dev and screenshotted /, /solutions, /zh-cn/solutions to confirm the new pricing tier and service card render correctly, and that the footer "We're hiring!" badge fix worked

Generated by Claude Code

claude added 2 commits July 17, 2026 09:29
- Add public/social.webp (converted from src/images/social.png via
  sharp): astro.config.mjs's Starlight og:image/twitter:image meta
  tags pointed at this path but the file never existed, so link
  previews for any docs page were broken.
- Point the signup modal's "Terms and Conditions" link at the
  terms-of-service page that already exists instead of "#".
- Remove the footer's dead "Careers"/"招聘" link (no careers page
  exists on the site) in both the en and zh-cn nav data.
- Fix the footer's "Consultation Services"/"技术咨询服务" link, which
  pointed at /services (404) instead of the actual /solutions route.
- Set package.json's empty "name" field to "airdb-website".
Pricing felt thin with only two plans and an unused third column
in the grid (the CSS was already built for lg:w-1/3). Refactored
PricingSection.astro from two hardcoded cards to a generic loop over
a `plans` array, and added a middle "Growth Plan" tier (en + zh-cn)
so the pricing page has a real starter/growth/enterprise ladder.
Feature lists on all three tiers got a bit more specific too. The
"Get a Custom Quote" CTA now points at /contact instead of "#".

Solutions page gets a sixth service, "Technical Advisory & Managed
IT Services" (en + zh-cn), which ties back to the "CTO/CIO/CISO/DPO
as a service" line already promised on the pricing page but never
covered as its own service on /solutions. Also corrected alt text
across all solutions.astro images, which still described the original
template's construction-site stock photos even though the actual
images were already swapped to AI/data-center imagery; fixed a
leftover "硬件和软件行业" (hardware and software industry) phrase in
the zh-cn page; and pointed the remaining dead "#" CTAs on this page
at /contact.

Fixed a regression surfaced while testing this: FooterSection.astro
picked the "We're hiring!" badge by hardcoded array index (Company
section, index 2), which used to line up with "Careers" before that
link was removed in a previous change — it had silently shifted onto
"Blog" instead. Removed the index-based badge since there's no
careers link for it to attach to anymore.
@bumu
bumu merged commit 2891060 into main Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants